Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GraphQL notification settings for MS Teams and Mattermost #10694

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

Dschoordsch
Copy link
Contributor

Description

Partially Fixes #10647
Adding the GraphQL types for notification settings for Mattermost and MS Teams.
The UI and honouring the settings in the notification manager will be done separately.

Demo

[If possible, please include a screenshot or gif/video, it'll make it easier for reviewers to understand the scope of the changes and how the change is supposed to work. If you're introducing something new or changing the existing patterns, please share a Loom and explain what decisions you've made and under what circumstances]

Testing scenarios

mutation NotificationSettings {
  setNotificationSetting(
    authId: "TeamMemberIntegrationAuth:1"
    event: meetingEnd
    isEnabled: false
  ) {
    __typename
    ...on ErrorPayload {
      error {
        message 
      }
    }
    ...on SetNotificationSettingSuccess {
      authId
      auth {
        id
        ...on TeamMemberIntegrationAuthWebhook {
          events
        }
      }
    }
  }  
}

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@Dschoordsch Dschoordsch changed the title Feat/10647/add mattermost notification settings feat: Add GraphQL notification settings for MS Teams and Mattermost Jan 16, 2025
@github-actions github-actions bot added size/l and removed size/m labels Jan 20, 2025
The settings don't work for it yet.
@Dschoordsch Dschoordsch merged commit 5cdaba2 into master Jan 21, 2025
7 checks passed
@Dschoordsch Dschoordsch deleted the feat/10647/addMattermostNotificationSettings branch January 21, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mattermost (in Parabol): Add notification settings
1 participant