Remove hint nc_header_collective but still allow collective I/O for header #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hint nc_header_collective has been removed.
ROMIO hint romio_no_indep_rw is now used to enable whether PnetCDF should make collective I/O calls for accessing file header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#104 add a new PnetCDF hint
nc_header_collectivewhich is not necessary,because we can simply check ROMIO hint
romio_no_indep_rwto serve thesame purpose. Thus, this PR removes PnetCDF hint
nc_header_collectiveadded in #104.
In all previous PnetCDF's releases, file header is written/read by rank 0 only
using MPI independent APIs. This can nullify ROMIO hint
romio_no_indep_rwif set by the user. To warrant no independent read/write, this PR first checks hint
romio_no_indep_rwand if set totrue, then all file header I/Os are doneusing MPI collective I/O calls, where only rank 0 makes non-zero length requests
while all others zero length (in order to participate the collective calls).