Fixes TypeError and infinite looping in MPITaskScheduler #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yadudoc
force-pushed
the
mpi_sched_fix
branch
from
6715018 to
f399687
Compare
* test_larger_jobs_prioritized checks to confirm the ordering of jobs in the backlog queue * test_hashable_backlog_queue tests to confirm that the PrioritizedTask dataclass avoid the priority queue failing to hash tasks with the same priority. * an extended test for new MPITaskScheduler logic
…g logic * `schedule_backlog_tasks` is now updated to fetch all tasks in the backlog_queue and then attempt to schedule them avoiding the infinite loop. * A new `PrioritizedTask` dataclass is added that disable comparison on the task: dict element. * The priority is set num_nodes * -1 to ensure that larger jobs get prioritized.
yadudoc
force-pushed
the
mpi_sched_fix
branch
from
6a4b1a1 to
22a4ce0
Compare
yadudoc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to fix the following bugs in the MPITaskScheduler:
schedule_backlog_tasksmethod takes tasks from the backlog and attempts to schedule them until the queue is empty. However since calling put_task pops the task back onto the backlog queue, this ends up in an infinite loop if there's at least 1 task that cannot be scheduled.TypeErrorunhashable type: dict.Changed Behaviour
Fixes
schedule_backlog_tasksis now updated to fetch all tasks in the backlog_queue and then attempt to schedule them avoiding the infinite loop.PrioritizedTaskdataclass is added that disable comparison on thetask: dictelement.num_nodes * -1to ensure that larger jobs get prioritized.Type of change
Choose which options apply, and delete the ones which do not apply.