Skip to content

Conversation

@TurboRx
Copy link
Contributor

@TurboRx TurboRx commented Oct 23, 2025

multiple critical issues found and fixed during a comprehensive codebase review, including runtime errors, TypeScript compilation issues, and documentation inconsistencies.

Copy link
Owner

@PartMan7 PartMan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, so none of these issues are 'critical', but the changes are still appreciated!

The one thing I'll ask you to change here is the removed LFs; I'd prefer for all my files to end with LF so that they're usable from terminals too

@PartMan7 PartMan7 changed the title Fix critical issues: import order, TypeScript syntax, type safety, and documentation chore: Clean up issues in import order and docs Oct 23, 2025
@PartMan7
Copy link
Owner

Other than the LFs mentioned above, the rest is much appreciated; thanks for finding these!

Copy link
Owner

@PartMan7 PartMan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! There's one URL missing but I'll update that one.

"@parcel/watcher-linux-x64-glibc": "^2.5.1"
}
}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh oops this one was missed

README.md Outdated
- [@PartMan7](https://github.com/PartMan7) (Parth Mane) - Lead Developer, Maintainer
- [@Audiino](https://github.com/Audiino) - Lead Artist, Maintainer, Victim of being asked to do stuff
- [@zxchan](https://github.com/singiamtel) - putting up with dumb questions
- [@zxchan](https://github.com/singiamtel) - putting up with dumb questions
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, it was just an accidental change nothing is changed here.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the change, then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants