-
Couldn't load subscription status.
- Fork 5
chore: Clean up issues in import order and docs #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, so none of these issues are 'critical', but the changes are still appreciated!
The one thing I'll ask you to change here is the removed LFs; I'd prefer for all my files to end with LF so that they're usable from terminals too
|
Other than the LFs mentioned above, the rest is much appreciated; thanks for finding these! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! There's one URL missing but I'll update that one.
| "@parcel/watcher-linux-x64-glibc": "^2.5.1" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh oops this one was missed
README.md
Outdated
| - [@PartMan7](https://github.com/PartMan7) (Parth Mane) - Lead Developer, Maintainer | ||
| - [@Audiino](https://github.com/Audiino) - Lead Artist, Maintainer, Victim of being asked to do stuff | ||
| - [@zxchan](https://github.com/singiamtel) - putting up with dumb questions | ||
| - [@zxchan](https://github.com/singiamtel) - putting up with dumb questions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, it was just an accidental change nothing is changed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the change, then?
multiple critical issues found and fixed during a comprehensive codebase review, including runtime errors, TypeScript compilation issues, and documentation inconsistencies.