Skip to content

Conversation

@johnsimons
Copy link
Member

@johnsimons johnsimons commented Nov 20, 2025

This PR is a spike on bringing ServicePulse into ServiceControl and hosting it as part of the ASP.NET Core server.

The way to review this PR is to ignore the first ~240 commits (this is just bringing the whole history from https://github.com/Particular/ServicePulse/tree/master/src/Frontend) and start the review from 6ca2cd3 (#5189)
image

Summary of changes:

  • It brings in the ServicePulse source code, including history (hence the reason for so many commits)
  • Adds the compiled artifacts to wwwroot and enables serving those via ASP.NET Core
  • Makes app.constants.js be served from the server
  • Makes app.constants JSON-based
  • Updated the UI to remove the need to show versions for ServiceControl and ServicePulse, given now ServicePulse and ServiceControl are merged/shipped together, so really a single version
  • Refactor to no longer use window.defaultConfig (this is an anti-pattern), instead create a module

dependabot bot and others added 30 commits June 20, 2025 22:03
Bumps [eslint](https://github.com/eslint/eslint) from 9.28.0 to 9.29.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v9.28.0...v9.29.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-version: 9.29.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [msw](https://github.com/mswjs/msw) from 2.9.0 to 2.10.2.
- [Release notes](https://github.com/mswjs/msw/releases)
- [Changelog](https://github.com/mswjs/msw/blob/main/CHANGELOG.md)
- [Commits](mswjs/msw@v2.9.0...v2.10.2)

---
updated-dependencies:
- dependency-name: msw
  dependency-version: 2.10.2
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…Frontend/types/node-24.0.3

Bump @types/node from 22.15.30 to 24.0.3 in /src/Frontend
…Frontend/vue-flow/core-1.45.0

Bump @vue-flow/core from 1.44.0 to 1.45.0 in /src/Frontend
…Frontend/eslint-9.29.0

Bump eslint from 9.28.0 to 9.29.0 in /src/Frontend
Bumps [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) from 8.34.1 to 8.35.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.35.0/packages/typescript-eslint)

---
updated-dependencies:
- dependency-name: typescript-eslint
  dependency-version: 8.35.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [prettier](https://github.com/prettier/prettier) from 3.5.3 to 3.6.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.5.3...3.6.0)

---
updated-dependencies:
- dependency-name: prettier
  dependency-version: 3.6.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Refactor AuditList component to use new MessageStatusIcon component
…ointlists

componentise endpoint list headers
Bumps the patch-updates group with 3 updates in the /src/Frontend directory: [lossless-json](https://github.com/josdejong/lossless-json), [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) and [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier).


Updates `lossless-json` from 4.1.0 to 4.1.1
- [Changelog](https://github.com/josdejong/lossless-json/blob/main/CHANGELOG.md)
- [Commits](josdejong/lossless-json@v4.1.0...v4.1.1)

Updates `@types/node` from 24.0.3 to 24.0.4
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `eslint-plugin-prettier` from 5.5.0 to 5.5.1
- [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/eslint-plugin-prettier@v5.5.0...v5.5.1)

---
updated-dependencies:
- dependency-name: lossless-json
  dependency-version: 4.1.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: patch-updates
- dependency-name: "@types/node"
  dependency-version: 24.0.4
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: patch-updates
- dependency-name: eslint-plugin-prettier
  dependency-version: 5.5.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: patch-updates
...

Signed-off-by: dependabot[bot] <support@github.com>
johnsimons and others added 29 commits October 27, 2025 20:03
Moves license related logic and data into a dedicated Pinia store for better state management and component reusability.
It also removes the computed properties from the vue component and places them in the store otherwise the computed props no longer work.
Also, fixed some of the schema
@johnsimons johnsimons self-assigned this Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants