Fix unit tests

Pathoschild · Nov 12, 2023 · ca6a1ac · ca6a1ac
1 parent 8e578c0
commit ca6a1ac
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 1 deletion.
diff --git a/src/SMAPI.ModBuildConfig.Analyzer.Tests/ContentManagerAnalyzerTests.cs b/src/SMAPI.ModBuildConfig.Analyzer.Tests/ContentManagerAnalyzerTests.cs
@@ -82,7 +82,7 @@ public void EmptyCode_HasNoDiagnostics()
         /// <param name="expression">The expression which should be reported.</param>
         /// <param name="netType">The net type name which should be reported.</param>
         /// <param name="suggestedProperty">The suggested property name which should be reported.</param>
-        [TestCase("Game1.content.Load<Dictionary<int, string>>(\"Data\\\\Fish\");", 0, "Data\\Fish", "System.Collections.Generic.Dictionary<System.Int32, System.String>", "System.Collections.Generic.Dictionary<System.String,System.String>")]
+        [TestCase("Game1.content.Load<Dictionary<int, string>>(\"Data\\\\Fish\");", 0, "Data\\Fish", "System.Collections.Generic.Dictionary<System.Int32,System.String>", "System.Collections.Generic.Dictionary<System.String,System.String>")]
         public void BadType_RaisesDiagnostic(string codeText, int column, string assetName, string expectedType, string suggestedType)
         {
             // arrange

diff --git a/src/SMAPI.ModBuildConfig.Analyzer.Tests/Mock/StardewValley/Game1.cs b/src/SMAPI.ModBuildConfig.Analyzer.Tests/Mock/StardewValley/Game1.cs
@@ -0,0 +1,7 @@
+namespace StardewValley
+{
+    public class Game1
+    {
+        public static LocalizedContentManager content = new();
+    }
+}
diff --git a/src/SMAPI.ModBuildConfig.Analyzer.Tests/Mock/StardewValley/LocalizedContentManager.cs b/src/SMAPI.ModBuildConfig.Analyzer.Tests/Mock/StardewValley/LocalizedContentManager.cs
@@ -0,0 +1,13 @@
+// ReSharper disable CheckNamespace, InconsistentNaming -- matches Stardew Valley's code
+// ReSharper disable UnusedMember.Global -- used dynamically for unit tests
+namespace StardewValley
+{
+    /// <summary>A simplified version of Stardew Valley's <c>StardewValley.LocalizedContentManager</c> class for unit testing.</summary>
+    public class LocalizedContentManager
+    {
+        public T Load<T>(string assetName)
+        {
+            return default!;
+        }
+    }
+}
diff --git a/src/SMAPI.ModBuildConfig.Analyzer/ContentManagerAnalyzer.cs b/src/SMAPI.ModBuildConfig.Analyzer/ContentManagerAnalyzer.cs
@@ -70,6 +70,9 @@ private void AnalyzeContentManagerLoads(SyntaxNodeAnalysisContext context)
             var memberAccess = invocation.Expression as MemberAccessExpressionSyntax;
             if (memberAccess == null || memberAccess.Name.Identifier.ValueText != "Load")
                 return;
+            string? loadNamespace = context.SemanticModel.GetSymbolInfo(memberAccess).Symbol?.ContainingNamespace.Name;
+            if (!(loadNamespace == "StardewValley" || loadNamespace == "StardewModdingAPI"))
+                return;
             // "Data\\Fish" -> Data\Fish
             string assetName = invocation.ArgumentList.Arguments[0].ToString().Replace("\"", "").Replace("\\\\", "\\");
 
@@ -78,6 +81,8 @@ private void AnalyzeContentManagerLoads(SyntaxNodeAnalysisContext context)
 
             if (this.OneSixRules.AssetMap.TryGetValue(assetName, out string expectedType))
             {
+                // delete `3 as I can't convince Roslyn and Cecil to agree
+                // TODO: Move into DataGeneration
                 expectedType = Regex.Replace(expectedType, "`\\d+", "");
                 if (genericArgument != expectedType)
                 {