Merge pull request #59 from PauloPortugal/fix/address-ansible-lint-er…

…rors

Fix/address ansible lint errors

.gitignore

@@ -5,4 +5,7 @@ playbook.retry
 .idea
 
 # Vagrant build folder
-.vagrant
+.vagrant
+
+# VS Code
+.vscode

handlers/freshclam.yml

@@ -1,6 +1,7 @@
 ---
 - name: Update freshClam database
   ansible.builtin.command: freshclam
+  changed_when: true
   become: true
   tags:
     - security

handlers/zshrc.yml

@@ -2,4 +2,5 @@
 - name: Source zshrc
   ansible.builtin.shell: |
     source ~/.zshrc
+  changed_when: true
   listen: source .zshrc

playbook.yml

@@ -19,10 +19,10 @@
 
   handlers:
     - name: Configure OS handler
-      import_tasks: handlers/os.yml
+      ansible.builtin.import_tasks: handlers/os.yml
 
     - name: Configure Freshclam OS
-      import_tasks: handlers/freshclam.yml
+      ansible.builtin.import_tasks: handlers/freshclam.yml
 
     - name: Configure .zshrc
-      import_tasks: handlers/zshrc.yml
+      ansible.builtin.import_tasks: handlers/zshrc.yml

roles/base/tasks/main.yml

@@ -35,24 +35,24 @@
     - aur
 
 - name: Configure NTP
-  import_tasks: ntp.yml
+  ansible.builtin.import_tasks: ntp.yml
 
 - name: Configure PIP
-  import_tasks: pip.yml
+  ansible.builtin.import_tasks: pip.yml
 
 - name: Configure Bash
-  import_tasks: bash.yml
+  ansible.builtin.import_tasks: bash.yml
 
 - name: Configure Zsh
-  import_tasks: zsh.yml
+  ansible.builtin.import_tasks: zsh.yml
 
 - name: Configure terminator
-  import_tasks: terminator.yml
+  ansible.builtin.import_tasks: terminator.yml
 
 - name: Creates Workspace directory
   ansible.builtin.file:
     path: /home/{{ user_name }}/Workspace
     state: directory
-    mode: 0755
+    mode: "0755"
   become_user: "{{ user_name }}"
   become: true

roles/base/tasks/ntp.yml

@@ -8,7 +8,7 @@
     - ntp
 
 - name: Set timezone to Europe/London
-  timezone:
+  community.general.timezone:
     name: Europe/London
   become: true
   tags:

roles/base/tasks/terminator.yml

@@ -3,7 +3,7 @@
   ansible.builtin.file:
     path: /home/{{ user_name }}/.config/terminator
     state: directory
-    mode: 0764
+    mode: "0764"
   become: true
   become_user: "{{ user_name }}"
   tags:
@@ -15,7 +15,7 @@
     dest: /home/{{ user_name }}/.config/terminator/config
     owner: "{{ user_name }}"
     group: "{{ user_name }}"
-    mode: 0644
+    mode: "0644"
   become: true
   become_user: "{{ user_name }}"
   tags:

roles/base/tasks/zsh.yml

@@ -28,7 +28,7 @@
     dest: /home/{{ user_name }}/.zshrc
     owner: "{{ user_name }}"
     group: "{{ user_name }}"
-    mode: 0644
+    mode: "0644"
   become: true
   become_user: "{{ user_name }}"
   when: not zsh_file_check.stat.exists

roles/development/tasks/emacs-config.yml

@@ -13,7 +13,7 @@
   ansible.builtin.shell: |
     set -o pipefail
     curl -L https://github.com/bbatsov/prelude/raw/master/utils/installer.sh | sh
-  when: not prelude_modules_exists.stat.exists
+  changed_when: not prelude_modules_exists.stat.exists
   become_user: "{{ user_name }}"
   become: true
   tags:
@@ -26,7 +26,7 @@
     dest: /home/{{ user_name }}/.emacs.d/
     owner: "{{ user_name }}"
     group: "{{ user_name }}"
-    mode: 0644
+    mode: "0644"
   become_user: "{{ user_name }}"
   become: true
   tags:

roles/development/tasks/main.yml

@@ -10,7 +10,7 @@
     - development
 
 - name: Configure Go
-  import_tasks: go.yml
+  ansible.builtin.import_tasks: go.yml
 
 - name: Install Developer Tools from Arch User Repository
   ansible.builtin.script: ../../../aur/install-aur.sh {{ item }}
@@ -25,13 +25,13 @@
     - aur
 
 - name: Install nvm
-  import_tasks: nvm.yml
+  ansible.builtin.import_tasks: nvm.yml
 
 - name: Configure docker
-  import_tasks: docker-config.yml
+  ansible.builtin.import_tasks: docker-config.yml
 
 - name: Configure Emacs
-  import_tasks: emacs-config.yml
+  ansible.builtin.import_tasks: emacs-config.yml
 
 - name: Configure Tesseract
-  import_tasks: tesseract.yml
+  ansible.builtin.import_tasks: tesseract.yml

roles/development/tasks/nvm.yml

@@ -1,6 +1,6 @@
 ---
 - name: Get latest release of the Node Version Manager (nvm) repository
-  github_release:
+  community.general.github_release:
     user: nvm-sh
     repo: nvm
     action: latest_release

roles/editors/tasks/main.yml

@@ -18,7 +18,7 @@
     - editors_aur
 
 - name: Setup default Git configuration
-  git_config:
+  community.general.git_config:
     name: "{{ item.name }}"
     scope: global
     value: "{{ item.value }}"

roles/gnome/tasks/dash-to-dock.yml

@@ -1,6 +1,6 @@
 ---
 - name: Dash to Dock - Set dash max icon size
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/dash-max-icon-size
     value: "64"
     state: present
@@ -10,7 +10,7 @@
     - dash-to-dock
 
 - name: Dash to Dock - Set dots colour
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/custom-theme-running-dots-color
     value: "'#ffffff'"
     state: present
@@ -20,7 +20,7 @@
     - dash-to-dock
 
 - name: Dash to Dock - Set dots border colour
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/custom-theme-running-dots-border-color
     value: "'#ffffff'"
     state: present
@@ -30,7 +30,7 @@
     - dash-to-dock
 
 - name: Dash to Dock - Set background colour
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/background-color
     value: "'#ffffff'"
     state: present
@@ -40,7 +40,7 @@
     - dash-to-dock
 
 - name: Dash to Dock - Set transparency mode
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/transparency-mode
     value: "'FIXED'"
     state: present
@@ -50,7 +50,7 @@
     - dash-to-dock
 
 - name: Dash to Dock - Set running indicator style
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/running-indicator-style
     value: "'DOTS'"
     state: present
@@ -60,7 +60,7 @@
     - dash-to-dock
 
 - name: Dash to Dock - Set background opacity
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/background-opacity
     value: "0.22"
     state: present
@@ -70,7 +70,7 @@
     - dash-to-dock
 
 - name: Dash to Dock - Set dock position
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/dock-position
     value: "'BOTTOM'"
     state: present
@@ -81,7 +81,7 @@
 
 # Enabled settings
 - name: Dash to Dock - Enable custom background color
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/custom-background-color
     value: "true"
     state: present
@@ -91,7 +91,7 @@
     - dash-to-dock
 
 - name: Dash to Dock - Enable custom-theme-shrink
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/custom-theme-shrink
     value: "true"
     state: present
@@ -101,7 +101,7 @@
     - dash-to-dock
 
 - name: Dash to Dock - Enable multi monitor
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/multi-monitor
     value: "true"
     state: present
@@ -112,7 +112,7 @@
 
 # Disabled settings
 - name: Dash to Dock - Disable fixed icon size
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/icon-size-fixed
     value: "false"
     state: present
@@ -122,7 +122,7 @@
     - dash-to-dock
 
 - name: Dash to Dock - Disable unity-backlit-items
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/unity-backlit-items
     value: "false"
     state: present
@@ -132,7 +132,7 @@
     - dash-to-dock
 
 - name: "Dash to Dock - Disable custom theme "
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/apply-custom-theme
     value: "false"
     state: present
@@ -142,7 +142,7 @@
     - dash-to-dock
 
 - name: Dash to Dock - Disable running indicator dominant color
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/running-indicator-dominant-color
     value: "false"
     state: present
@@ -152,7 +152,7 @@
     - dash-to-dock
 
 - name: Dash to Dock - Disable straight corners
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/force-straight-corner
     value: "false"
     state: present
@@ -162,7 +162,7 @@
     - dash-to-dock
 
 - name: Dash to Dock - Disable show apps at top
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/show-apps-at-top
     value: "false"
     state: present
@@ -172,7 +172,7 @@
     - dash-to-dock
 
 - name: Dash to Dock - Disable extend height
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/extend-height
     value: "false"
     state: present
@@ -182,7 +182,7 @@
     - dash-to-dock
 
 - name: Dash to Dock - Disable dock fixed
-  dconf:
+  community.general.dconf:
     key: /org/gnome/shell/extensions/dash-to-dock/dock-fixed
     value: "false"
     state: present