-
Notifications
You must be signed in to change notification settings - Fork 20
fix content type validation for OAS3 #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,7 +37,7 @@ function buildValidations(referenced, dereferenced, receivedOptions) { | |
| const schemas = {}; | ||
|
|
||
| const basePaths = dereferenced.servers && dereferenced.servers.length | ||
| ? dereferenced.servers.map(({ url }) => new URL(url).pathname) | ||
| ? dereferenced.servers.map(({ url }) => new URL(url, 'http://foo').pathname) | ||
| : [dereferenced.basePath || '/']; | ||
|
|
||
| Object.keys(dereferenced.paths).forEach(currentPath => { | ||
|
|
@@ -123,8 +123,10 @@ function buildRequestValidator(referenced, dereferenced, currentPath, currentMet | |
| } | ||
|
|
||
| if (localParameters.length > 0 || options.contentTypeValidation) { | ||
| requestSchema.parameters = buildParametersValidation(localParameters, | ||
| dereferenced.paths[currentPath][currentMethod].consumes || dereferenced.paths[currentPath].consumes || dereferenced.consumes, options); | ||
| const contentTypes = isOpenApi3 ? | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i know the code base isn't pretty to say least, but i suggest that will try not to make it even harder to read. what do you say about extracting this to a function?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i'd also suggest adding a test for covering both cases when content type exists and missing from the request body |
||
| Object.keys( get(dereferenced.paths[currentPath][currentMethod], 'requestBody.content') || {} ) : | ||
| ( dereferenced.paths[currentPath][currentMethod].consumes || dereferenced.paths[currentPath].consumes || dereferenced.consumes ); | ||
| requestSchema.parameters = buildParametersValidation(localParameters, contentTypes, options); | ||
| } | ||
|
|
||
| return requestSchema; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why
'http://foo'?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there has to be an origin, but any origin works (we just want to extract the pathname)