Skip to content

Fixed issues with CancelTransaction and CheckTransaction #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kadirovazizbek wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed issues with CancelTransaction and CheckTransaction #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca900d7
Fixed issue with wrong params for find()
kadirovazizbek Mar 3, 2022
6df0091
If datetime is null, return 0
kadirovazizbek Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Paycom/Application.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ private function CancelTransaction()

// change order state to cancelled
$order = new Order($this->request->id);
$order->find($this->request->params);
$order->find(['order_id' => $found->order_id]);
$order->changeState(Order::STATE_CANCELLED);

// send response
Expand All @@ -298,7 +298,7 @@ private function CancelTransaction()
case Transaction::STATE_COMPLETED:
// find order and check, whether cancelling is possible this order
$order = new Order($this->request->id);
$order->find($this->request->params);
$order->find(['order_id' => $found->order_id]);
if ($order->allowCancel()) {
// cancel and change state to cancelled
$found->cancel(1 * $this->request->params['reason']);
Expand Down
3 changes: 3 additions & 0 deletions Paycom/Format.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,9 @@ public static function datetime2timestamp($datetime)
if ($datetime) {
return 1000 * strtotime($datetime);
}
if (is_null($datetime)) {
return 0;
}

return $datetime;
}
Expand Down