Fix : Linkages for no visible bindings warnings #3442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infotroph
approved these changes
Feb 20, 2025
| # new enviroment for spin up data | ||
| linkages_env_spinup <- new.env() | ||
| spinup_file <- file.path(outdir, runid,list.files(file.path(outdir, runid))[grep(list.files(file.path(outdir, runid)),pattern='linkages')][1]) | ||
| load(spinup_file, envir = linkages_env_spinup) |
There was a problem hiding this comment.
Thanks for pulling the file path out to a variable for a nice readability improvement!
Merged
via the queue into
PecanProject:develop
with commit Feb 20, 2025
9832559
17 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following changes in the package:
Fixes a part of the issue #2758 : Resolved the issues related to "no visible bindings" warnings in the package linkages. All relevant variables have been correctly scoped and assigned, ensuring that no variables are left unreferenced or improperly bound.
Loading Environment Fix: Updated the logic for loading the output data to prevent conflicts with variables in the environment. Specifically, when no survivors are found in the initial output, the backup spinup file is now correctly loaded into a separate environment or with renamed variables to avoid overwriting existing data.
Reference Log Update: Updated the reference.log file to reflect these changes
These changes should resolve the issues previously encountered with missing or unreferenced bindings, improve the environment management during data loading, and maintain the integrity of the logging.
Rechecked for the remaining issues , if any by Rcmdcheck .