Skip to content
This repository has been archived by the owner on Jul 11, 2024. It is now read-only.

Update contributors.js with new contributors #35

Merged
merged 7 commits into from
Jan 22, 2024
Merged

Update contributors.js with new contributors #35

merged 7 commits into from
Jan 22, 2024

Conversation

Sweetdevil144
Copy link
Contributor

Fixes #32
As Described by @RohanSasne , following changes were made :

  • New contributors were added with provided information.
  • Contributors' whose positions required changes were made as required.

@Sweetdevil144
Copy link
Contributor Author

In addition to the modifications I've proposed, I've noticed some inconsistencies within the README.md file. Given the minor nature of these changes, I believe it would be appropriate to address them within this pull request rather than creating a separate one. Would you agree that these markdown issues should be addressed here? Please note that these corrections involve altering three specific lines only.

Copy link
Collaborator

@allgandalf allgandalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the following comments from the issue #32 :

Also, I wonder if we could create a section on project alumni. Probably just names not pictures. There we could add a number of people who came and went since that page was last updated (grad students, postdocs, GSOC students, etc)

And/or we could link to the github project contribitors page https://github.com/PecanProject/pecan/graphs/contributors

@Sweetdevil144
Copy link
Contributor Author

Also, I wonder if we could create a section on project alumni. Probably just names not pictures. There we could add a number of people who came and went since that page was last updated (grad students, postdocs, GSOC students, etc)

Yeah Sure. I'm thinking to proceed as follow :

  • Creating a new component called AlumniList.js which I can integrate in people.js as follow :
       <h2 style={{ textAlign: "center",margin:'0.5rem' }}>Project Alumni</h2>
       <AlumniList/>

This section will be integrated below the <CardList/> component and will contain names of Alumni as requested.

  • For this, can you provide me a data or any list which contain such sections? for example, it may contain list of postdoc candidates working on the project as well as names of all GSoC candidates which appeared in past years since the beginning of the Project?
  • Other than this, I will look into resources from Pecan Page and GSoC Page with Names, OR simply number of People who have been here.
  • About this :

And/or we could link to the github project contribitors page https://github.com/PecanProject/pecan/graphs/contributors

I think we should include a link at the footer with alt of Contributors in the section of Contribute to Code.
What do you think about this?

@Sweetdevil144
Copy link
Contributor Author

@RohanSasne I'm proceeding forward with the changes I've proposed in above message. All edits and responses are welcome.

Created a seperate Alumni section enlisting previous GSoC contributors
Copy link
Collaborator

@allgandalf allgandalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry for the delay in review, super busy these days :)

I appreciate your efforts @Sweetdevil144 , just completed the review, thanks a lot for the PR, we're good to go!

You can also find issues in our main project repository : https://github.com/PecanProject/pecan/issues

I really wish to see you around more often with us and hope you keep contributing to our community :)

@allgandalf allgandalf merged commit 5776b1c into PecanProject:main Jan 22, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the People Page
2 participants