refactor: Use snprintf instead of sprintf for creating ISO time string

PeculiarVentures · Jun 3, 2024 · 20b80fb · 20b80fb
1 parent 248e0e4
commit 20b80fb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/pkcs11.cpp b/src/pkcs11.cpp
@@ -51,15 +51,15 @@ napi_value create_date_utc_property(napi_env env, CK_UTF8CHAR_PTR utcTime)
   napi_get_named_property(env, utcTimeConstructor, "Date", &utcTimeConstructor);
   napi_value utcTimeDate;
 
-  if (utcTime == nullptr || utcTime[0] == '\0' || utcTime[0] == ' ')
+  if (utcTime == nullptr || utcTime[0] == '\0' || utcTime[0] == ' ' || strlen((char *)utcTime) < 14)
   {
     napi_new_instance(env, utcTimeConstructor, 0, nullptr, &utcTimeDate);
     return utcTimeDate;
   }
 
   // create string from utcTime
   char isoTime[20];
-  sprintf(isoTime, "%c%c%c%c-%c%c-%c%cT%c%c:%c%c:%c%cZ", utcTime[0], utcTime[1], utcTime[2], utcTime[3], utcTime[4], utcTime[5], utcTime[6], utcTime[7], utcTime[8], utcTime[9], utcTime[10], utcTime[11], utcTime[12], utcTime[13]);
+  snprintf(isoTime, sizeof(isoTime), "%c%c%c%c-%c%c-%c%cT%c%c:%c%c:%c%cZ", utcTime[0], utcTime[1], utcTime[2], utcTime[3], utcTime[4], utcTime[5], utcTime[6], utcTime[7], utcTime[8], utcTime[9], utcTime[10], utcTime[11], utcTime[12], utcTime[13]);
   napi_value utcTimeValue;
   napi_create_string_utf8(env, isoTime, NAPI_AUTO_LENGTH, &utcTimeValue);