Add native CockroachDB connector support #3861
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
viragtripathi
requested a deployment
to
external-contributor
GitHub Actions
Waiting
viragtripathi
requested a deployment
to
external-contributor
GitHub Actions
Waiting
viragtripathi
requested a deployment
to
external-contributor
GitHub Actions
Waiting
viragtripathi
requested a deployment
to
external-contributor
GitHub Actions
Waiting
viragtripathi
force-pushed
the
feat/cockroachdb-integration
branch
from
eb56599 to
31e5672
Compare
viragtripathi
requested a deployment
to
external-contributor
GitHub Actions
Waiting
viragtripathi
requested a deployment
to
external-contributor
GitHub Actions
Waiting
viragtripathi
requested a deployment
to
external-contributor
GitHub Actions
Waiting
viragtripathi
requested a deployment
to
external-contributor
GitHub Actions
Waiting
Implements full CockroachDB integration as a source peer with: - Native Go connector using pgx driver (490 lines) - Schema introspection (GetSchemas, GetTables, GetColumns) - Connection support for local and cloud deployments - TLS support (disabled by default for easier local development) - SSH tunnel support in backend (no UI for Cloud-focused deployments) - Version validation and variant detection - Complete UI integration for peer creation - Rust analyzer and catalog support Tested with both local CockroachDB (insecure) and cloud instances (with TLS). Note: SQL syntax support (CREATE PEER FROM COCKROACHDB) will be added in a follow-up PR once sqlparser dependency is updated.
viragtripathi
force-pushed
the
feat/cockroachdb-integration
branch
from
31e5672 to
f16c84e
Compare
viragtripathi
requested a deployment
to
external-contributor
GitHub Actions
Waiting
viragtripathi
requested a deployment
to
external-contributor
GitHub Actions
Waiting
viragtripathi
requested a deployment
to
external-contributor
GitHub Actions
Waiting
viragtripathi
requested a deployment
to
external-contributor
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements full CockroachDB integration as a source peer, following the same patterns as existing PostgreSQL and MySQL connectors.
What's included
Backend:
Frontend:
Testing performed
Design Decisions
TLS Default: Set to
false(matching Postgres) for easier local development. Cloud users will enable it as needed.SSH Support: Backend implementation included but no UI exposed. CockroachDB Cloud deployments (primary use case) don't require SSH tunnels, keeping the UI simpler and more focused.
Note on SQL syntax
SQL syntax support (
CREATE PEER FROM COCKROACHDB) requires updates to the sqlparser dependency and will be added in a follow-up PR.Files changed
23 files changed, 936 insertions(+), 2 deletions(-)