Modernize usage of CMake #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbockelm
force-pushed
the
modernize_cmake
branch
2 times, most recently
from
d2fc683 to
5724d8e
Compare
- Use targets instead of environment variables where possible - Use XRootD's find_package over local one - Remove compatibility macros with very old CMake - Add improved std::filesystem detection - Always run with `-Werror` in Debug mode
bbockelm
force-pushed
the
modernize_cmake
branch
from
5724d8e to
74d9dce
Compare
|
@jhiemstrawisc - any interest in reviewing this? I feel like there's enough CMake arcana here that I might be the only one who's comfortable working in it :/ |
|
At the very least, I'll take a peak to see if I can learn anything 🤓 A quick glance tells me I probably won't have meaningful comments, though. |
jhiemstrawisc
approved these changes
Jan 8, 2025
|
@jhiemstrawisc - one thing of note is that, with this refactor, I've started to dig into the automatic dependency resolution / downloads for CMake. This would allow us to bootstrap the build from nothing - eg, if you don't have XRootD, CMake could install and configure it from scratch. (That's not here but there's potential for the future!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of spring cleaning for how we invoke CMake.