🔧 Properly handle openssl version > 1.0.X #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryannowarm Thanks for the fix. Can you please add a news file for the release notes, e.g. |
madchutney
changed the title
ryannowarm
force-pushed
the
fix_ssl_warning
branch
2 times, most recently
from
41d78a3
to
840f126
Compare
Handle the case when the major version is greater than 1 and the minor version is greater than 0. For example, my current host uses openssl 1.1.1.
ryannowarm
force-pushed
the
fix_ssl_warning
branch
from
840f126
to
ca0cd08
Compare
|
I've pushed a more elegant fix as well as the news entry. |
madchutney
approved these changes
Sep 13, 2019
| @@ -107,7 +107,7 @@ def check_openssl_version(): | |||
| minor = int(match.group(3)) | |||
| patch = int(match.group(4)) | |||
|
|
|||
| if major >= 1 and minor >= 0 and patch >= 2: | |||
| if (major, minor, patch) >= (1, 0, 2): | |||
There was a problem hiding this comment.
Nice use of tuple comparison, hadn't though of doing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the case when the major version is greater than 1 and the minor
version is greater than 0. For example, my current host uses openssl
1.1.1.