Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retire harmony (remove defaults) #112

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

splch
Copy link
Contributor

@splch splch commented Aug 19, 2024

we're retiring our harmony qpu ❤️ so this pr removes that qpu default

@Alex-Preciado
Copy link
Contributor

Alex-Preciado commented Aug 19, 2024

Hey @splch , thank you so much for this contribution!! It looks like the PR is still failing some tests, but we’ll be happy to support once it’s ready for review. 🚀

[sc-71691]

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (e5beee9) to head (00ad29c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   96.93%   95.95%   -0.99%     
==========================================
  Files           5        5              
  Lines         326      321       -5     
==========================================
- Hits          316      308       -8     
- Misses         10       13       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splch
Copy link
Contributor Author

splch commented Sep 23, 2024

Hi @Alex-Preciado! I got the tests passing but I see an indirect change caused the code coverage to fail. Can we still merge and cover that different test in a separate PR?

@Alex-Preciado
Copy link
Contributor

Hi @splch , apologies for the delay. I was away for a couple of weeks and I missed your message. It looks like some tests are still not passing after your most recent commit. Let me know if you need assistance.

@Alex-Preciado
Copy link
Contributor

Hi @splch, this PR has become stale. It seems the tests were still failing after your last merge from master. Are you still interested in merging this PR? Would you like assistance identifying the root cause of the problem? Let me know how you’d like to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants