-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retire harmony (remove defaults) #112
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 96.93% 95.95% -0.99%
==========================================
Files 5 5
Lines 326 321 -5
==========================================
- Hits 316 308 -8
- Misses 10 13 +3 ☔ View full report in Codecov by Sentry. |
Hi @Alex-Preciado! I got the tests passing but I see an indirect change caused the code coverage to fail. Can we still merge and cover that different test in a separate PR? |
Hi @splch , apologies for the delay. I was away for a couple of weeks and I missed your message. It looks like some tests are still not passing after your most recent commit. Let me know if you need assistance. |
Hi @splch, this PR has become stale. It seems the tests were still failing after your last merge from master. Are you still interested in merging this PR? Would you like assistance identifying the root cause of the problem? Let me know how you’d like to proceed. |
we're retiring our harmony qpu ❤️ so this pr removes that qpu default