Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Proof of Concept implementations for CompactLCU CompactState #6749

Open
wants to merge 3 commits into
base: trotter_resources
Choose a base branch
from

Conversation

Jaybsoni
Copy link
Contributor

@Jaybsoni Jaybsoni commented Jan 2, 2025

Context:
As we develop the resource estimation functionality, we are realizing that the size of our systems of interest are larger than can be expressed in a pennylane circuit (at this stage). Furthermore, even at a high-level, expressing a gate or subroutine as a pennylane operation requires specifying the parameters and hyper-parameters which may not be required if we just want to obtain resources without simulation.

This "Input Problem" is addressed through the creation of two classes CompactLCU and CompactState which act as abstract inputs that can be passed into PL operations to perform resource estimates.

@Jaybsoni Jaybsoni added the do not merge ⚠️ Do not merge the pull request until this label is removed label Jan 2, 2025
@Jaybsoni Jaybsoni requested review from willjmax and soranjh January 2, 2025 18:01
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@Jaybsoni
Copy link
Contributor Author

Jaybsoni commented Jan 2, 2025

@soranjh, @willjmax

No need to review this PR, just tagging you to keep you informed.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.60%. Comparing base (808cde8) to head (36463a8).

Additional details and impacted files
@@                Coverage Diff                 @@
##           trotter_resources    #6749   +/-   ##
==================================================
  Coverage              99.60%   99.60%           
==================================================
  Files                    478      478           
  Lines                  45045    45045           
==================================================
  Hits                   44868    44868           
  Misses                   177      177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge ⚠️ Do not merge the pull request until this label is removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant