Add error if differentiating diff_method=None #6770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
…yLaneAI/pennylane into no-grad-on-diff-method-none
|
@albi3ro Should this be part of the release? |
Nope. It's changing architectural components and core behavior. |
albi3ro
added a commit
that referenced
this pull request
Jan 15, 2025
…ck` (#6788) **Context:** While we have logic for sampling with jax, it does not really integrate very well into the workflow. While you can technically set `diff_method=None` right now and jit the execution end-to-end, trying to jit `diff_method=None` will cause incomprehensible error messages on non-DQ devices. We want to *forbid* differentiation `diff_method=None`, but keep a way to jit a finite shot execution. **Description of the Change:** In order to allow jitting finite shot executions, we need a way for the device to be able to configure whether or not the data is converted to numpy. To do so, we simply add another property to the `ExecutionConfig`, `convert_to_numpy`. If `False`, then we will not use a `pure_callback` to convert the parameters to numpy. If `True`, we use a `pure_callback` and convert the parameters to numpy. **Benefits:** Speed ups due to being able to jit the entire execution.  **Possible Drawbacks:** `ExecutionConfig` gets an addtional property, making it more complicated. **Related GitHub Issues:** Fixes #6054 Fixes #3259 Blocks #6770 --------- Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
albi3ro
changed the title
albi3ro
commented
Jan 15, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6770 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 476 476
Lines 45178 45181 +3
=======================================
+ Hits 44999 45002 +3
Misses 179 179 ☔ View full report in Codecov by Sentry. |
albi3ro
commented
Jan 15, 2025
JerryChen97
approved these changes
Jan 15, 2025
Co-authored-by: Yushao Chen (Jerry) <chenys13@outlook.com>
This was referenced Jan 16, 2025
albi3ro
added a commit
that referenced
this pull request
Jan 16, 2025
**Context:** PR #6770 accidentally broke lightning, becasue we are now sending numpy data to lightning instead of autograd. The autograd arrays had slightly different casting rules. With numpy, we are no longer implicitly casting to integers. **Description of the Change:** Always cast the input to `BasisState` to integers. **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
If someone tries to differentiate a qnode that has
diff_method=None, they may get less-than-useful error message. We also assume that no interface parameters are used withdiff_method=NoneDescription of the Change:
Uses the ML boundary when
diff_method=Noneand raises an informative error if differentiation is requested.Benefits:
ML parameters can be used with
diff_method=None, and incorrect usage provides good error messages.Possible Drawbacks:
Related GitHub Issues:
Solves #6769 [sc-81490]