Add upper bound to summation of the QFT equation in QPE tutorial #1606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your preview is ready 🎉!You can view your changes here
|
josh146
approved these changes
Nov 23, 2025
Member
josh146
left a comment
josh146
left a comment
There was a problem hiding this comment.
Nice thanks for this @antalszava! I'll also tag @KetpuntoG on my end as co-author of this demo just to double check.
Member
|
@antalszava do you mind also updating the Edit: nevermind, looks like I have edit permissions :) |
daniela-angulo
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The expression for QFT in the QPE tutorial has a summation that could do with an upper bound and this PR adds that.