Merged
Conversation
…IEssentialsRoomFusionController feat: add help request timeout functionality to IEssentialsRoomFusion…
…troller.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…troller.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…IEssentialsRoomFusionController fix: ensure proper disposal of help request timeout timer and improve…
clean up XML comments and improve property definitions in EssentialsRoomConfig
…g.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…g.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…g.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…g.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…g.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…t-keys-to-room-config feat: Add on/off dsp keys to EssentialsAvRoomPropertiesConfig
ndorin
approved these changes
Dec 9, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges changes from the main branch to the development branch, primarily focusing on standardizing XML documentation comments and adding new configuration properties for DSP presets and help request timeouts.
Key Changes:
- Standardized XML documentation placement across configuration classes, moving comments from after attributes to before them
- Added new DSP preset configuration properties (
DefaultOnDspPresetKey,DefaultOffDspPresetKey) toEssentialsAvRoomPropertiesConfig - Implemented help request timeout functionality with configurable timer support in the Fusion controller
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/PepperDash.Essentials.Core/Room/Config/EssentialsRoomConfig.cs |
Standardized XML documentation placement, added missing documentation for properties and constructors, and introduced new DSP preset configuration properties |
src/PepperDash.Essentials.Core/Fusion/IEssentialsRoomFusionControllerPropertiesConfig.cs |
Added configuration properties for help request timeout feature (UseTimeoutForHelpRequests, HelpRequestTimeoutMs) |
src/PepperDash.Essentials.Core/Fusion/IEssentialsRoomFusionController.cs |
Implemented help request timeout timer functionality with automatic cancellation, added timer cleanup logic, and uncommented previously disabled help desk response handling |
src/PepperDash.Essentials.Core/Devices/SourceListItem.cs |
Removed duplicate XML documentation comment for the Name property |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
For future reference, we normally create a temporary branch from main and merge that into dev. |
andrew-welker
approved these changes
Dec 9, 2025
Contributor
Author
|
Understood, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.