Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

377 revirew fak #118

Merged
merged 10 commits into from
Jul 14, 2023
Merged

377 revirew fak #118

merged 10 commits into from
Jul 14, 2023

Conversation

wbaccinelli
Copy link
Contributor

bscheltinga
bscheltinga approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@bscheltinga bscheltinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Walter, looks good. I have a few comments for you.

For the state machine, I found it quite hard to do the review...

Rasa_Bot/actions/actions_first_aid_kit.py Show resolved Hide resolved
Rasa_Bot/actions/helper.py Show resolved Hide resolved
Rasa_Bot/actions/requirements-actions.txt Outdated Show resolved Hide resolved
Rasa_Bot/data/rules/rules_idle_commands.yml Show resolved Hide resolved
onboarding/requirements.txt Outdated Show resolved Hide resolved
scheduler/celery_tasks.py Outdated Show resolved Hide resolved
scheduler/requirements.txt Outdated Show resolved Hide resolved
@wbaccinelli wbaccinelli mentioned this pull request Jul 14, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

6.7% 6.7% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@wbaccinelli wbaccinelli merged commit 93d64ec into main Jul 14, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bscheltinga bscheltinga bscheltinga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review First Aid KIt
2 participants
@wbaccinelli @bscheltinga