fixing everything #123

wbaccinelli · 2023-07-14T09:08:42Z

Fixes PerfectFit-project/virtual-coach-issues#382

raar1

OK, nice. So, am I understanding correctly that you have moved the message sending code (that used to be in Rasa) to a celery task, so it's now fully async? The delay issue is no longer noticeable?

raar1 · 2023-07-14T14:19:48Z

scheduler/celery_tasks.py

@@ -395,11 +393,38 @@ def resume_and_trigger(self,  # pylint: disable=unused-argument
    if response_resume.status_code != 200:
        raise Exception()

+    response_intent = send_trigger(user_id, trigger)
+    if response_intent != 200:
+        print('Exception, retrying')


Can we log this instead of printing it, or is that not appropriate here? Also I would make the message slightly more descriptive - maybe "Exception during resume_and_trigger" or something, to at least say which function it was happening it (same for the others).

Absolutely yes, I will do this.

raar1 · 2023-07-14T14:20:37Z

scheduler/celery_tasks.py

+        recipient_id = mes['recipient_id']
+        message = mes['text']
+        client.post_message(int(recipient_id), message)
+        if ENVIRONMENT == 'prod':


There are no delays simulated in testing?

Yeah, maybe I'd better keep it always active indeed.

scheduler/celery_tasks.py

wbaccinelli · 2023-07-14T14:38:29Z

OK, nice. So, am I understanding correctly that you have moved the message sending code (that used to be in Rasa) to a celery task, so it's now fully async? The delay issue is no longer noticeable?

@raar1 Exactly, and it runs so smoothly now that I could cry.