Skip to content

Commit

Permalink
refactor: replace hardcoded test tags with newly-created C values
Browse files Browse the repository at this point in the history
  • Loading branch information
@charliemangano
charliemangano committed Oct 31, 2024
1 parent 018d183 commit 1319bf1
Show file tree
Hide file tree
Showing 2 changed files with 150 additions and 132 deletions.
80 changes: 47 additions & 33 deletions app/src/androidTest/java/com/android/periodpals/ui/alert/AlertScreenTest.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import androidx.compose.ui.test.onNodeWithText
import androidx.compose.ui.test.performClick
import androidx.compose.ui.test.performTextInput
import androidx.test.ext.junit.runners.AndroidJUnit4
import com.android.periodpals.resources.C
import com.android.periodpals.ui.navigation.NavigationActions
import com.android.periodpals.ui.navigation.Route
import com.android.periodpals.ui.navigation.Screen
Expand Down Expand Up @@ -41,111 +42,124 @@ class AlertScreenTest {
@Test
fun allComponentsAreDisplayed() {

composeTestRule.onNodeWithTag("alertInstruction").assertIsDisplayed()
composeTestRule.onNodeWithTag("alertProduct").assertIsDisplayed()
composeTestRule.onNodeWithTag("alertUrgency").assertIsDisplayed()
composeTestRule.onNodeWithTag("alertLocation").assertIsDisplayed()
composeTestRule.onNodeWithTag("alertMessage").assertIsDisplayed()
composeTestRule.onNodeWithTag("bottomNavigationMenu").assertIsDisplayed()
composeTestRule.onNodeWithTag("topBar").assertIsDisplayed()
composeTestRule.onNodeWithTag("goBackButton").assertIsNotDisplayed()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.INSTRUCTION_TEXT).assertIsDisplayed()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.PRODUCT_FIELD).assertIsDisplayed()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.URGENCY_FIELD).assertIsDisplayed()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.LOCATION_FIELD).assertIsDisplayed()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.MESSAGE_FIELD).assertIsDisplayed()
composeTestRule
.onNodeWithTag("alertSubmit")
.assertIsDisplayed()
.assertTextEquals("Ask for Help")
.onNodeWithTag(C.Tag.BottomNavigationMenu.BOTTOM_NAVIGATION_MENU)
.assertIsDisplayed()
composeTestRule.onNodeWithTag(C.Tag.TopBar.TOP_BAR).assertIsDisplayed()
composeTestRule.onNodeWithTag(C.Tag.TopBar.GO_BACK_BUTTON).assertIsNotDisplayed()
composeTestRule
.onNodeWithTag(C.Tag.AlertScreen.SUBMIT_BUTTON)
.assertIsDisplayed()
.assertTextEquals("Ask for Help")
}

@Test
fun createValidAlert() {

composeTestRule.onNodeWithTag("alertProduct").performClick()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.PRODUCT_FIELD).performClick()
composeTestRule.onNodeWithText("Pads").performClick()

composeTestRule.onNodeWithTag("alertUrgency").performClick()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.URGENCY_FIELD).performClick()
composeTestRule.onNodeWithText("!! Medium").performClick()

composeTestRule.onNodeWithTag("alertLocation").performTextInput("Rolex")
composeTestRule.onNodeWithTag("alertMessage").performTextInput("I need help finding a tampon")
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.LOCATION_FIELD).performTextInput("Rolex")
composeTestRule
.onNodeWithTag(C.Tag.AlertScreen.MESSAGE_FIELD)
.performTextInput("I need help finding a tampon")

composeTestRule.onNodeWithTag("alertSubmit").performClick()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.SUBMIT_BUTTON).performClick()
verify(navigationActions).navigateTo(Screen.ALERT_LIST)
}

@Test
fun createInvalidAlertNoProduct() {

composeTestRule.onNodeWithTag("alertUrgency").performClick()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.URGENCY_FIELD).performClick()
composeTestRule.waitForIdle()
composeTestRule.onNodeWithText("!! Medium").performClick()
composeTestRule.waitForIdle()

composeTestRule.onNodeWithTag("alertLocation").performTextInput("Rolex")
composeTestRule.onNodeWithTag("alertMessage").performTextInput("I need help finding a tampon")
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.LOCATION_FIELD).performTextInput("Rolex")
composeTestRule
.onNodeWithTag(C.Tag.AlertScreen.MESSAGE_FIELD)
.performTextInput("I need help finding a tampon")

composeTestRule.onNodeWithTag("alertSubmit").performClick()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.SUBMIT_BUTTON).performClick()
verify(navigationActions, never()).navigateTo(any<TopLevelDestination>())
verify(navigationActions, never()).navigateTo(any<String>())
}

@Test
fun createInvalidAlertNoUrgencyLevel() {

composeTestRule.onNodeWithTag("alertProduct").performClick()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.PRODUCT_FIELD).performClick()
composeTestRule.waitForIdle()
composeTestRule.onNodeWithText("Pads").performClick()
composeTestRule.waitForIdle()

composeTestRule.onNodeWithTag("alertLocation").performTextInput("Rolex")
composeTestRule.onNodeWithTag("alertMessage").performTextInput("I need help finding a tampon")
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.LOCATION_FIELD).performTextInput("Rolex")
composeTestRule
.onNodeWithTag(C.Tag.AlertScreen.MESSAGE_FIELD)
.performTextInput("I need help finding a tampon")

composeTestRule.onNodeWithTag("alertSubmit").performClick()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.SUBMIT_BUTTON).performClick()
verify(navigationActions, never()).navigateTo(any<TopLevelDestination>())
verify(navigationActions, never()).navigateTo(any<String>())
}

@Test
fun createInvalidAlertNoLocation() {

composeTestRule.onNodeWithTag("alertProduct").performClick()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.PRODUCT_FIELD).performClick()
composeTestRule.waitForIdle()
composeTestRule.onNodeWithText("Pads").performClick()
composeTestRule.waitForIdle()

composeTestRule.onNodeWithTag("alertUrgency").performClick()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.URGENCY_FIELD).performClick()
composeTestRule.waitForIdle()
composeTestRule.onNodeWithText("!! Medium").performClick()
composeTestRule.waitForIdle()

composeTestRule.onNodeWithTag("alertMessage").performTextInput("I need help finding a tampon")
composeTestRule
.onNodeWithTag(C.Tag.AlertScreen.MESSAGE_FIELD)
.performTextInput("I need help finding a tampon")

composeTestRule.onNodeWithTag("alertSubmit").performClick()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.SUBMIT_BUTTON).performClick()
verify(navigationActions, never()).navigateTo(any<TopLevelDestination>())
verify(navigationActions, never()).navigateTo(any<String>())
}

@Test
fun createInvalidAlertNoMessage() {
// Leave message empty
composeTestRule.onNodeWithTag("alertProduct").performClick()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.PRODUCT_FIELD).performClick()
composeTestRule.waitForIdle()
composeTestRule.onNodeWithText("Pads").performClick()
composeTestRule.waitForIdle()

composeTestRule.onNodeWithTag("alertUrgency").performClick()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.URGENCY_FIELD).performClick()
composeTestRule.waitForIdle()
composeTestRule.onNodeWithText("!! Medium").performClick()
composeTestRule.waitForIdle()

composeTestRule.onNodeWithTag("alertLocation").performTextInput("Rolex")
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.LOCATION_FIELD).performTextInput("Rolex")

composeTestRule.onNodeWithTag("alertSubmit").performClick()
composeTestRule.onNodeWithTag(C.Tag.AlertScreen.SUBMIT_BUTTON).performClick()
verify(navigationActions, never()).navigateTo(any<TopLevelDestination>())
verify(navigationActions, never()).navigateTo(any<String>())
}

@Test
fun createInvalidAlertAllEmptyFields() {
composeTestRule.onNodeWithTag("alertSubmit").assertIsDisplayed().performClick()
composeTestRule
.onNodeWithTag(C.Tag.AlertScreen.SUBMIT_BUTTON)
.assertIsDisplayed()
.performClick()
verify(navigationActions, never()).navigateTo(any<TopLevelDestination>())
verify(navigationActions, never()).navigateTo(any<String>())
}
Expand Down
Loading

0 comments on commit 1319bf1

Please sign in to comment.