Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make layout responsive to all screen orientations #75

Closed
3 tasks done
taghizadlaura opened this issue Oct 28, 2024 · 4 comments · Fixed by #109
Closed
3 tasks done

Make layout responsive to all screen orientations #75

taghizadlaura opened this issue Oct 28, 2024 · 4 comments · Fixed by #109
Assignees

Comments

@taghizadlaura
Copy link
Contributor

taghizadlaura commented Oct 28, 2024

Description:

Even if the task is called "Make layout responsive to all screen orientations", we will only focus for this task sprint on blocking the screen orientation to "portrait" mode.

Acceptance Criteria:

Specific, measurable criteria to confirm the task is complete.

  • Functional Requirements: The screen is blocked in "portrait" mode even if you turn the phone.
  • Quality Standards: Ensure it only use essential code that requires minimal changes in the future to ensure it remains efficient and maintainable.
  • Testing Requirements: Ensure >=80% code coverage.

Preconditions:

  • Access to the latest version of Android Studio and the project repository.
  • Familiarity with Android manifest configurations and activity lifecycle management.

Steps to Completion:

Break down the task into actionable steps to guide work progression and ensure alignment with the sprint plan:

  • Step 1: Modify the AndroidManifest.xml to set the screen orientation to "portrait" for the desired activities.
  • Step 2: Test manually the changes
  • Step 3: Review code for efficiency and maintainability, ensuring minimal essential code is used.

Points to Consider / Known Risks:

  • Potential Risks: User experience may be negatively impacted on devices primarily used in landscape mode.
  • Technical Constraints: Limited testing on various device sizes and configurations may affect orientation behavior.
  • Dependencies: May require updates to the UI layout to ensure proper functionality in portrait mode only.
@taghizadlaura taghizadlaura self-assigned this Oct 28, 2024
@francelu
Copy link
Contributor

Here is the feedback from the M1:

## UI

We checked whether the elements of your app's UI are consistent (fonts, colors, etc.) and whether the layout is responsive (i.e., adapts to different screen sizes and orientations).

It does not seem to fit all screen orientations (you can block it otherwise to portait), and the dark mode makes texts less readable.

For this part, you received 3 points out of a maximum of 5.

We will go with blocking the screen to portrait view. Less work, don't see why landscape mode would be good for user experience.

@francelu
Copy link
Contributor

I see you've already done a first step. If you've created a branch, please link it to this issue, would be very much appreciated. Thanks ! PO :)

@taghizadlaura
Copy link
Contributor Author

I linked a branch to this issue, but I had to rename it, and now the issue is linked to a non-existent branch since it didn't detect the changes. Does anyone have any ideas on how I can solve this problem?

@taghizadlaura
Copy link
Contributor Author

I found how to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants