Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/style/layout-orientation : Make layout responsive to all screen orientations #109

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

taghizadlaura
Copy link
Contributor

Make layout responsive to all screen orientations

Description

This PR introduces a restriction on the orientation of MainActivity, ensuring it can only be displayed in portrait mode. This change enhances user experience by preventing unexpected landscape orientation. It closes issue #75 .

Changes

  • Added android:screenOrientation="portrait" to MainActivity in AndroidManifest.xml.

Files

Modified

  • AndroidManifest.xml

Testing

Tested the application on multiple devices to confirm that MainActivity remains in portrait mode and does not switch to landscape.

@taghizadlaura taghizadlaura self-assigned this Oct 31, 2024
@taghizadlaura taghizadlaura linked an issue Oct 31, 2024 that may be closed by this pull request
3 tasks
@francelu francelu removed the request for review from agonzalez-r October 31, 2024 16:34
Copy link
Contributor

@francelu francelu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for doing the research ! :))

Copy link
Contributor

@charliemangano charliemangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work!

@taghizadlaura taghizadlaura merged commit a24dd60 into main Nov 1, 2024
2 checks passed
@taghizadlaura taghizadlaura deleted the fix/style/layout-orientation branch November 1, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make layout responsive to all screen orientations
3 participants