Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/navigation/bottom-navigation-menu-ui-tests : Fix BottomNavigationMenu UI tests for M1 #105

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

taghizadlaura
Copy link
Contributor

@taghizadlaura taghizadlaura commented Oct 31, 2024

Rename Test Methods in BottomNavigationMenuTest

Description

The tests were already complete and functional. This PR closes issue #97 but aims to improve code readability. It only introduces naming consistency in the BottomNavigationMenuTest class by renaming test methods to match the established format used in other test classes.

Changes

  • Updated the names of the test methods to follow the conventions used in other test classes.

Files

Modified

  • BottomNavigationMenuTest.kt

Testing

All tests have been run to ensure functionality remains unchanged after renaming. The tests were already complete and functional.

@taghizadlaura taghizadlaura linked an issue Oct 31, 2024 that may be closed by this pull request
2 tasks
@taghizadlaura taghizadlaura mentioned this pull request Oct 31, 2024
11 tasks
Copy link
Contributor

@francelu francelu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

LGTM.

Important

Code Quality

  • Changes made to maintain consistency with tests in other files are appreciated.

Functionality

  • The modifications ensure expected behaviors are properly validated.

Steps before PR approved

  • None, great job!

@taghizadlaura taghizadlaura self-assigned this Oct 31, 2024
Copy link
Contributor

@Harrish92 Harrish92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taghizadlaura taghizadlaura merged commit 00cd95b into main Oct 31, 2024
2 checks passed
@taghizadlaura taghizadlaura deleted the fix/navigation/bottom-navigation-menu-ui-tests branch October 31, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix UI tests for M1: BottomNavigationMenu
3 participants