Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc/sonarcloud setup #107

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Misc/sonarcloud setup #107

merged 4 commits into from
Nov 1, 2024

Conversation

agonzalez-r
Copy link
Member

@agonzalez-r agonzalez-r commented Oct 31, 2024 •
edited
Loading

Complete SonarCloud set up

Description

This PR (attempts) closes issue #104, by completing the integration of SonarCloud to the repository (following this documentation).

What was already done:

  • Organisation in SonarCloud is created
  • SonarCloud successfully added to Installed GitHub Apps of PeriodPals
  • SONAR_TOKEN successfully added to the organization's secret
  • uploading report to SonarCloud during workflow

Changes

Files

Added

  • sonar-project.properties: contains project key, organization key

Modified

  • .github/workflows/ci.yml: added SonarCloud Scanning

Testing

no possible testing

@agonzalez-r agonzalez-r added the bug Something isn't working label Oct 31, 2024
@agonzalez-r agonzalez-r self-assigned this Oct 31, 2024
charliemangano
charliemangano approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@charliemangano charliemangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This seems to be following best practices and to follow the documentation properly. As we can't test it until it's pushed, we'll see if it works then

coaguila
coaguila approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@coaguila coaguila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sonar-project.properties Outdated Show resolved Hide resolved
@agonzalez-r agonzalez-r linked an issue Nov 1, 2024 that may be closed by this pull request
Set up sonarcloud directly in the repository #104
Closed
2 tasks
@agonzalez-r agonzalez-r merged commit 4e9d265 into main Nov 1, 2024
2 checks passed
@agonzalez-r agonzalez-r deleted the misc/sonarcloud-setup branch November 1, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coaguila coaguila coaguila approved these changes

@charliemangano charliemangano charliemangano approved these changes

Assignees

@agonzalez-r agonzalez-r

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up sonarcloud directly in the repository
3 participants
@agonzalez-r @charliemangano @coaguila