Feat/alert/UI: AlertScreen UI #24

agonzalez-r · 2024-10-10T17:40:07Z

Overview

The AlertScreen is where users can customise their alert and submit it so that the other users will receive it. They will then be displayed in the AlertListScreen #23.

Key Features

Dropdown menu with the period product option the user prefers
Dropdown menu with the urgency levels
Followed the Figma, but I think there is room for improvement for the design

Future improvements

An Alert will be created and store in the repository once the model and viewModel are finished
I created the data class for the Alerts in the branch Feat/alert/model Model and ViewModel for Alerts: list of tasks #17, all necessary information will be provided in this screen in order to effectively create an instance
For the moment the Location is just a string, next sprint we will implement a Location data class with coordinates so that they can be displayed in a map
UI-wise, I think this screen can be improved, maybe do a round button and better arrange the entry components

Tests

Verified that all components are correctly displayed and the interaction is correct

…ation

…avigation in `MainActivity`

…ailures

…s on click

Added UI components for product selection, urgency level, location, and message input Includes a submit button for saving alerts Needs linking to ViewModel for functionality

fix: change labels for the dropdown menus in AlertScreen

sonarqubecloud · 2024-10-11T07:27:07Z

Quality Gate failed

Failed conditions
74.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

lazarinibruno

Thanks for your work!

Comments

The inclusion of tests verifying that everything is correctly displayed is top!
The UI covers the basic features that the screen will have.
I like how you modularized the code by creating your own custom ExposedDropDownMenuSample composable.

Improvements

As you mentioned, the UI could be improved to make it feel more modern-looking. Some improvements could be:

The explanation at the top of the screen could be shortened or even omitted.
Having a button that upon clicking on it, cycles through the menstrual products.
The same for the urgency level

Steps before merge

LGTM

Feat/profile/create

Added UI components for product selection, urgency level, location, and message input Includes a submit button for saving alerts Needs linking to ViewModel for functionality

fix: change labels for the dropdown menus in AlertScreen

Changed AGP version from 8.7.0 to 8.6.1 to fix error "The project is using an incompatible version (AGP 8.7.0) of the Android Gradle plugin. Latest supported version is AGP 8.6.0" when building.

Added UI components for product selection, urgency level, location, and message input Includes a submit button for saving alerts Needs linking to ViewModel for functionality

fix: change labels for the dropdown menus in AlertScreen

lazarinibruno

LGMT

Feat/navigation: navigations actions, title bar and bottom bar

Added UI components for product selection, urgency level, location, and message input Includes a submit button for saving alerts Needs linking to ViewModel for functionality

fix: change labels for the dropdown menus in AlertScreen

charliemangano

lgtm!
thanks for the changes

francelu and others added 24 commits October 8, 2024 17:34

feat: implement navigation actions and add tests

8eda1cc

feat: implement top navigation menu, navigation actions pass my tests

3ec1b9c

fix: removed useless TODO

1e2ce70

fix: remove useless TODO

9cf2beb

Merge remote-tracking branch 'origin/feat-navigation' into feat-navig…

4783ce6

…ation

fix: display title using CenterAlignedTopAppBar

5547907

feat: add test tags for UI components

254d3b2

feat: create UI for "create profile" screen

3c5c356

style: Resize profile picture logo for better visibility

f535ab4

feat: integrate supabase into the project for data query

3044197

chore: merge main into feature-branch

8023e90

feat: update navigation with BottomNavigationMenu

85ca9b5

Add option for user to choose profile picture

c37dd9d

feat: add TopAppBar component to standardize screen UI and update n…

dd13f3f

…avigation in `MainActivity`

fix: remove preview of [Scaffold] component to prepare for pull request

4922555

fix: remove failing example test causing CI failures

6d6ccf9

fix: comment out tests referencing "Auth Screen" to troubleshoot CI f…

d932537

…ailures

fix: reformat code using ktfmt

2acc890

test: Ensure that UI elements are present and profile picture respond…

c8865c4

…s on click

feat: implement UI for AlertScreen with dropdowns and text fields

2bd81f4

Added UI components for product selection, urgency level, location, and message input Includes a submit button for saving alerts Needs linking to ViewModel for functionality

test: add UI tests for Alert Screen components

47e1fa0

fix: change labels for the dropdown menus in AlertScreen

fix: comment out navigation in PeriodPalsApp to avoid CI failures

8bf686b

fix: comment out Auth calls to avoid CI failures

7f12bdd

fix: delete sample test file causing problems with the CI

17cf680

lazarinibruno previously approved these changes Oct 11, 2024

View reviewed changes

francelu and others added 4 commits October 11, 2024 09:29

fix: remove redundant test class to fix CI failure

e013a74

fix: align versions of dependencies to make build work

d0c96d4

fix: change android emulator task in ci

84f61f2

fix: modify force avd creation to true to fix crashing android emulator

bbbc532

Harrish92 and others added 19 commits October 13, 2024 18:43

fix: improve validation logic for date of birth in CreateProfile screen

0729554

test: add UI tests for BottomNavigationMenu

58bbb5b

test: add UI tests for TopAppBar

c898ec1

Merge pull request #20 from PeriodPals/feat/profile/create

3c9ecc7

Feat/profile/create

fix: throw exception on back button press without action

e7a6982

style: format ktfmt

ef404e5

chore: merge with main

ed38556

chore: clean up dependencies in libs.versions.toml

f7d0011

feat: implement UI for AlertScreen with dropdowns and text fields

159793e

Added UI components for product selection, urgency level, location, and message input Includes a submit button for saving alerts Needs linking to ViewModel for functionality

test: add UI tests for Alert Screen components

c5589bf

fix: change labels for the dropdown menus in AlertScreen

fix: delete sample test file causing problems with the CI

981b869

fix: separate Test functions for maintainability and readability

d59ec5d

Merge remote-tracking branch 'origin/feat/alert/ui' into feat/alert/ui

3203d68

fix: change AGP version in libs.versions.toml for compatibility (#33)

4c260e4

Changed AGP version from 8.7.0 to 8.6.1 to fix error "The project is using an incompatible version (AGP 8.7.0) of the Android Gradle plugin. Latest supported version is AGP 8.6.0" when building.

feat: implement UI for AlertScreen with dropdowns and text fields

bfa0cb9

Added UI components for product selection, urgency level, location, and message input Includes a submit button for saving alerts Needs linking to ViewModel for functionality

test: add UI tests for Alert Screen components

85f311d

fix: change labels for the dropdown menus in AlertScreen

fix: delete sample test file causing problems with the CI

fba0dff

fix: separate Test functions for maintainability and readability

0b106d1

Merge remote-tracking branch 'origin/feat/alert/ui' into feat/alert/ui

0a807e2

lazarinibruno approved these changes Oct 14, 2024

View reviewed changes

francelu and others added 6 commits October 14, 2024 13:50

chore: merge with main

2803775

Merge pull request #21 from PeriodPals/feat/navigation

17719dd

Feat/navigation: navigations actions, title bar and bottom bar

feat: implement UI for AlertScreen with dropdowns and text fields

038d82e

Added UI components for product selection, urgency level, location, and message input Includes a submit button for saving alerts Needs linking to ViewModel for functionality

test: add UI tests for Alert Screen components

8a364a8

fix: change labels for the dropdown menus in AlertScreen

fix: separate Test functions for maintainability and readability

48a46f3

Merge remote-tracking branch 'origin/feat/alert/ui' into feat/alert/ui

f24563f

charliemangano approved these changes Oct 14, 2024

View reviewed changes

agonzalez-r merged commit 2bad641 into main Oct 14, 2024
2 checks passed

agonzalez-r deleted the feat/alert/ui branch October 14, 2024 14:33

charliemangano linked an issue Oct 14, 2024 that may be closed by this pull request

Create Alert Screen #14

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/alert/UI: AlertScreen UI #24

Feat/alert/UI: AlertScreen UI #24

agonzalez-r commented Oct 10, 2024

sonarqubecloud bot commented Oct 11, 2024

lazarinibruno left a comment

lazarinibruno left a comment

charliemangano left a comment

Feat/alert/UI: AlertScreen UI #24

Feat/alert/UI: AlertScreen UI #24

Conversation

agonzalez-r commented Oct 10, 2024

Overview

Key Features

Future improvements

Tests

sonarqubecloud bot commented Oct 11, 2024

Quality Gate failed

lazarinibruno left a comment

Choose a reason for hiding this comment

Comments

Improvements

Steps before merge

lazarinibruno left a comment

Choose a reason for hiding this comment

charliemangano left a comment

Choose a reason for hiding this comment