Define Model for Supabase authentication #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the app name from SampleApp to PeriodPals and cascaded the change throughout. Added basic dependencies as well as Supabase dependencies.
Updated Kotlin version from 1.9.0 to 2.0.0-RC1 for compatibility with kotlinx.serialization.Serializable.
`ExampleRobolectricTest` was acting up because of a reference to a useless second activity that was deleted. Kept the commented out code as example.
Created interface `com.android.periodpals.model.auth.AuthModel`. For now, it has three functions: `login`, `register` and `logout`. They can be called from the View Model with an email and a password (except `logout` which does not take arguments).
Created class `com.android.periodpals.model.auth.AuthModelSupabase`, implementing interface `AuthModel`. It overrides every function from its interface.
Changed the functions' signatures in `AuthModel` and `AuthModelSupabase`.
…ct `onFailure` signature Added `isUserLoggedIn` function in `AuthModel`. Changed the `onFailure` lambdas' signature to take an `Exception` as argument instead of an `Error`.
…k if user logged in method Surrounded calls on Supabase client with `try-catch` and use newly added `onSuccess` and `onFailure` lambdas. Implemented `isUserLoggedIn` function to check whether or not the user is logged in. Takes into account session timeout.
… purposes The `SupabaseClient` was impossible to mock because of the dependencies coming from the plugins. Therefore, I added a wrapper to the Supabase `PluginManager` that for now is only useful for the `Auth` plugin. Also implemented its use in `AuthModelSupabase`.
For now, `register success`, `login success` and `isUserLoggedIn success` do not work because of mocking issues.
Used the mocking functions properly on call to `signUpWith`.
Changed the argument matcher for a nullable argument from `any` to `anyOrNull`.
Used the mocking functions properly on call to `signInWith`.
Deleted problematic `ExampleInstrumentedTest.kt` and `ExampleRobolectricTest.kt` as they were imported from the Sample App we started from.
…iodpals into feat/authentication/model # Conflicts: # app/src/main/java/com/android/periodpals/MainActivity.kt
…hentication/model # Conflicts: # gradle/libs.versions.toml
coaguila
requested review from
charliemangano and
lazarinibruno
and removed request for
charliemangano
lazarinibruno
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Cool stuff
- Amazing tests! I like the structure of the tests, checking whether each function of the Model works as expected both in successful and unsuccessful scenarios.
- Code runs locally
Improvements
- Adding some comments to the code would imporve readability and improve the review process :3
Steps before merge
LGTM
agonzalez-r
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Very nice work!
Comments
- Besides, changing the error messages for Log.e I think there is no further improvements at this stage
- Very clean implementation: PluginManagerWrapper
- Excellent tests using Mockito
Improvements
- Changing the return type of the function
isUserLoggedInto boolean?
Steps before merge
LGTM
| Log.d(TAG, "register: successfully registered the user") | ||
| onSuccess() | ||
| } catch (e: Exception) { | ||
| Log.d(TAG, "register: failed to register the user: ${e.message}") |
There was a problem hiding this comment.
Nitpick: use Log.e for errors for better readability of the logs. Check documentation
app/src/main/java/com/android/periodpals/model/auth/AuthModelSupabase.kt
Show resolved
Hide resolved
…hentication/model # Conflicts: # app/build.gradle.kts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define Model for Supabase authentication
Description:
This PR introduces new features related to authentication, along with corresponding unit tests.
Key Changes:
Authentication Model:
AuthModel.ktfor handling authentication processes. This file includes logic for user authentication, token management, and user session handling.AuthModelSupabase.ktto integrate with Supabase's backend services.Plugin Manager wrapper:
SupabaseClient.pluginManagerfor testing purposes. This does not change the behavior, just allows mocking on the client.Unit Tests:
Created unit tests to verify the functionality of the authentication model and plugin manager:
Improvements:
We could implement authentication via a third party like Google.