Feat/authentication/UI

[francelu]

Overview

This PR introduces the Sign-In and Sign-Up authentication screens.

Key Features

• Sign-In Screen:

  • Validates email and password inputs with error messages for invalid entries.
  • Will navigate unregistered users to the Sign-Up screen.

• Sign-Up Screen:

  • Validates email, password, and password confirmation with error feedback.

• AuthSharedComposables.kt:

  • Shared UI components for consistent design and reduced code duplication.

• Testing:

  • UI tests cover validation and error handling for both screens.

Next Steps

• Review and provide feedback for merging into the main branch.

[charliemangano]

Very nice UI! Conforms to the Figma, great job!

Comments

• The composable ErrorMessage is not directly related to authentication and should be moved to another file. Maybe have com.android.periodpals.ui.components folder and put it there. This would improve general organization and make it easier for us later down the line.
• The ErrorMessage composable tests the observable String message. I think this should be done outside of it, in SignInScreen and SignUpScreen to improve readability and modularity.

Improvements

Next time, try and do smaller PRs. The SignIn.kt and SignUp.kt could have been separated into two smaller PRs. This would make it easier to review as well as improve general team organisation.

Steps before merge

Everything listed into the "Comments" section.
Don't forget to pull from main to get the AGP version bug fixed (see #32 #33).

[charliemangano]

lgtm!
Thank you for implementing the changes

[Harrish92]

Summary:

Great work on implementing the sign-in and sign-up screens! The code is well-structured and easy to follow. The use of Compose components and state management is effective and clean.

Suggestions:

For future improvements, consider improving the validation logic for an email address. A valid email address typically has four parts:

• Recipient name
• @ symbol
• Domain name
• Top-level domain

This will help in maintaining data integrity. Keep up the good work!