Test/e2e/adapt existing tests #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increases timeout to 50s for CI. Added `.performScrollTo` everywhere applicable. Cleared the text fields in EditProfile screen before inputting new values. Added inline comments and docs for clarity.
fix/misc/fix-e2e : Add tests to e2e branch
…c/fix-e2e-handle-push-perm-request # Conflicts: # app/src/androidTest/java/com/android/periodpals/endtoend/EndToEndM1.kt # app/src/androidTest/java/com/android/periodpals/endtoend/EndToEndM2.kt
…-perm-request test/misc/fix-e2e-handle-push-perm-request : Fix end-to-end to handle push notification permission request dialog
- RLS changed for users insertion. - Trouble deleting the account.
- Ensured activity is finished on tear down.
- Draft of e2e sign-up.
2 tasks
charliemangano
approved these changes
Dec 20, 2024
agonzalez-r
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Summary
These tests cleverly and effectively test the user flows.
Important (which includes)
Code Quality
[This includes readability, consistency]
Functionality
- Code is very clean and consistent
Documentation
- Good documentation, using
steps()improves readability greatly.
Suggestions
- Respond or implement my nitpicks
Steps before PR approved
LGTM
app/src/androidTest/java/com/android/periodpals/endtoend/EndToEndSignUp.kt
Show resolved
Hide resolved
app/src/androidTest/java/com/android/periodpals/endtoend/EndToEndSignUp.kt
Show resolved
Hide resolved
app/src/androidTest/java/com/android/periodpals/endtoend/EndToEndSignUp.kt
Show resolved
Hide resolved
app/src/androidTest/java/com/android/periodpals/endtoend/EndToEndSignUp.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/android/periodpals/endtoend/EndToEndSignIn.kt
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt Existing End-to-End tests
Description
This PR introduces the setup and tear down in existing end-to-end authentication and profile tests. It closes issue #322.
Changes
In all
ProfileScreens, I don't test for contribution and no review card since we're going to clean up the UI on unimplemented features.Authentication
I separated the sign-in and sign-up tests since they should be independent.
Sign-In
Sign-Up
Tear down: There's no tear down. However, we do delete the account going through theSettingsScreenand the delete button.Profile
Files
Added
app/src/androidTest/java/com/android/periodpals/endtoend/EndToEndProfile.ktapp/src/androidTest/java/com/android/periodpals/endtoend/EndToEndSignIn.ktapp/src/androidTest/java/com/android/periodpals/endtoend/EndToEndSignUp.ktDependencies Added
None.
Testing
Conducted end-to-end tests for sign-in, sign-up, and profile edit flows to ensure proper setup and tear down.