Fix/misc/auth map extract strings #335
Conversation
- Add string resources for SignInScreen (instruction, button text, toast messages) to `strings.xml`. - Refactor SignInScreen to use the newly added string resources. - Update tests to verify usage of the correct string resources.
- Add string resources for SignUpScreen (instruction, button text, toast messages) to `strings.xml`. - Refactor SignUpScreen to use the newly added string resources. - Update tests to verify usage of the correct string resources.
- Add string resources for MapScreen (screen title, marker title, tile URLs, and tile names) to `strings.xml`. - Refactor MapScreen to use the newly added string resources. - Update tests to verify usage of the correct string resources.
There was a problem hiding this comment.
I verified that the text in the Sign In, Sign Up, and Map screens is correct. I noticed a small error:
There should be a space between both sentences.
Moreover, I think it is best if you wait until I merge #303 because it introduces lots of changes in the Map screen.
@lazarinibruno Moreover, during this morning's meeting, we said that this task will include a lot of changes. Hence, we will have to merge carefully anyway (before or after your other merge). |
Add a space in the correct string.xml text (sign_in_no_account_text and sign_up_already_account_text)
# Conflicts: # app/src/main/res/values/strings.xml
|
Sign In, Sign Up, and Map texts in
strings.xmlDescription
This PR introduces string resources for the Sign In, Sign Up, and Map screens to improve readability and maintainability across the app. It ensures the content of these screens is easily managed through the
strings.xmlfile. This update closes issue #334 (and part of #328).Changes
SignInScreen,SignUpScreen,MapScreen) to use the newly added string resources, ensuring consistency and ease of maintenance.Files
Added
Modified
SignInScreen.kt(updated to use string resources fromstrings.xml)SignUpScreen.kt(updated to use string resources fromstrings.xml)MapScreen.kt(updated to use string resources fromstrings.xml)res/values/strings.xml(new strings added for Sign In, Sign Up, and Map)Removed
Dependencies Added
Testing
The Sign In, Sign Up, and Map screens have been updated to ensure the correct string resources are being used. Relevant tests have been adjusted to verify proper usage of the new resources.