Fix/misc/profile settings extract strings #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add string resources for CreateProfileScreen (screen title, radius explanation text) to `strings.xml`. - Refactor CreateProfileScreen to use the newly added string resources. - Update tests to verify usage of the correct string resources.
- Add string resource for EditProfileScreen (screen title) to `strings.xml`. - Refactor EditProfileScreen to use the newly added string resource. - Update tests to verify usage of the correct string resource.
- Add string resources for ProfileScreen (screen title, default name, default description, user status, number of interactions, reviews title, and no reviews message) to `strings.xml`. - Refactor ProfileScreen to use the newly added string resources. - Update tests to verify usage of the correct string resources.
- Add string resources for SettingsScreen (screen title, comments, notifications, themes, account management, dialog text, log messages, and toast messages) to `strings.xml`. - Refactor SettingsScreen to use the newly added string resources. - Update tests to verify usage of the correct string resources.
charliemangano
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Summary
Very nice refactoring of our string constants, thank you for the work!
Important
Code Quality
This improves consistency and readability, very nice!
Functionality
Works as before, all good here!
Testing
Good adaptation of the tests to fetch from the xml.
Documentation
No notes!
Suggestions
See comments. You also forgot to replace some strings in the Profile screen tests at around line 230 (GitHub wouldn't let me directly post a comment for some reason, sorry).
Steps before PR approved
See comments, as well as the forgotten strings mentioned. Otherwise, LGTM
Harrish92
approved these changes
Dec 18, 2024
app/src/main/java/com/android/periodpals/ui/profile/EditProfile.kt
Outdated
Show resolved
Hide resolved
…-strings # Conflicts: # app/src/main/res/values/strings.xml
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Profile, Edit Profile, Profile, and Settings texts in
strings.xmlDescription
This PR introduces string resources for the Create Profile, Edit Profile, Profile, and Settings screens to improve readability and maintainability across the app. It ensures the content of these screens is easily managed through the
strings.xmlfile. This update closes issue #336 (and part of #328).Changes
CreateProfileScreen,EditProfileScreen,ProfileScreen,SettingsScreen) to use the newly added string resources, ensuring consistency and ease of maintenance.Files
Added
Modified
CreateProfileScreen.kt(updated to use string resources fromstrings.xml)EditProfileScreen.kt(updated to use string resources fromstrings.xml)ProfileScreen.kt(updated to use string resources fromstrings.xml)SettingsScreen.kt(updated to use string resources fromstrings.xml)res/values/strings.xml(new strings added for Create Profile, Edit Profile, Profile, and Settings)Removed
Dependencies Added
Testing
The Create Profile, Edit Profile, Profile, and Settings screens have been updated to ensure the correct string resources are being used. Relevant tests have been adjusted to verify proper usage of the new resources.