Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve navigation and sign-in and sign-up flows #58

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Conversation

francelu
Copy link
Contributor

Assure that the M1 flows work.

@francelu francelu linked an issue Oct 18, 2024 that may be closed by this pull request
@francelu francelu marked this pull request as draft October 18, 2024 07:12
@francelu francelu self-assigned this Oct 18, 2024
@francelu francelu marked this pull request as ready for review October 18, 2024 07:13
# Conflicts:
#	app/src/androidTest/java/com/android/periodpals/ui/authentication/SignUpTest.kt
#	app/src/main/java/com/android/periodpals/MainActivity.kt
#	app/src/main/java/com/android/periodpals/ui/authentication/SignIn.kt
#	app/src/main/java/com/android/periodpals/ui/authentication/SignUp.kt
Copy link
Contributor

@taghizadlaura taghizadlaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sign up with wrong password is not perfect.

Copy link
Contributor

@charliemangano charliemangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. we will come back to it to clean up at a late date

@francelu francelu merged commit 2feb0e8 into main Oct 18, 2024
2 checks passed
@francelu francelu deleted the test/flow branch October 18, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check flows on screens, check for bug
3 participants