fix/authentication/signin-ui-tests : Fix and complete UI tests for SignInScreen #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `com.linkedin.dexmaker:dexmaker-mockito-inline` dependency to enable Mockito inline for androidTests Fix comes from 2776ce7.
2 tasks
added 4 commits
October 28, 2024 18:59
Uncommented the existing (partly wrong) tests, corrected them and created new ones. Used mocking for `NavigationActions` and `AuthViewModel` to be able to check for calls to them. Used a `companion object` to have a reusable valid email and password. The tests now check for: * display of all components * correct errors showing up when invalid attempt (empty email or password) * not trying to log in the user if invalid attempt * valid attempt navigates to next screen * valid attempt logs in the user * click on sign up navigates to SignUp screen
Changed deprecated `ClickableText` to a `Text` with a `clickable` attribute on its modifier. This makes it so that the `signUpHereNavigatesToSignUpScreen` test can detect calls to `navigationActions`
Added a `Row` with content two different `Text`s, once for non-clickable text ("Not registered yet? "), and one for clickable text ("Sign up here!").
coaguila
approved these changes
Oct 29, 2024
app/src/androidTest/java/com/android/periodpals/ui/authentication/SignInTest.kt
Show resolved
Hide resolved
app/src/androidTest/java/com/android/periodpals/ui/authentication/SignInTest.kt
Show resolved
Hide resolved
taghizadlaura
requested changes
Oct 31, 2024
app/src/androidTest/java/com/android/periodpals/ui/authentication/SignInTest.kt
Show resolved
Hide resolved
app/src/androidTest/java/com/android/periodpals/ui/authentication/SignInTest.kt
Outdated
Show resolved
Hide resolved
This should be handled at the VM level, so those tests would be out of the scope of this PR. |
Replaced ``when`(navigationActions.currentRoute()).thenReturn(Route.ALERT_LIST) ` with correct return screen (`Screen.SIGN_IN`). Added check for not calling the VM in `emptyPasswordDoesNotCallVM`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and complete UI tests for SignInScreen
Description
This PR introduces new tests for the SignIn screen and fixes the old ones. It also fixes the problems pointed out by said new tests. It closes issue #71 and fixes part of #63 .
Changes
Added dependencies to make mockito work in androidTests (this was also done in
mainand later merged into this branch, so I'll ignore it in the rest of this PR).Properly mocked
NavigationActionsand added verification of correct navigation. Also added checks for the correct calls to theAuthViewModelon valid attempts and for no calls to theAuthViewModelon invalid attempts. Removed irrelevant tests (tested for behavior of VM, not the point here).Invalid attempts are ones which have an empty email or password.
Fixed the problems pointed out by the added tests (two calls to
logInWithEmailinstead of one on valid attempt, call tonavigationActionnot detected when trying to sign up).Files
Added
None
Modified
app/src/androidTest/java/com/android/periodpals/ui/alert/SignInScreenTest.kt: modified, removed and added testsapp/src/main/java/com/android/periodpals/ui/alert/SignInScreen.kt: fixed problems pointed out by new testsRemoved
None
Dependencies Added
None
Testing
All UI tests for
SignInScreenpass. They should be complete enough.