fix/authentication/signup-ui-tests : Fix UI tests for M1: SignUp #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
taghizadlaura
changed the title
taghizadlaura
changed the title
charliemangano
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Summary
These tests are very complete, good job! Small changes here and there, check the comments!
Important
Code Quality
Very well formatted code, very consistent as well. I like that you extracted email and password variations in a companion object, it helps with consistency and error checking.
Functionality
I think the tests check for the proper things, and correctly. Be careful of edge cases though, see comments.
Testing
The tests pass and are very complete! Great job:)
Documentation
Code is self-documenting thanks to the function and variable clear nomenclature!
Suggestions
See comments
Steps before PR approved
See comments. Any comment that is not annotated with "nitpick" has to be resolved before I approve this PR.
app/src/androidTest/java/com/android/periodpals/ui/authentication/SignUpTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/android/periodpals/ui/authentication/SignUpTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/com/android/periodpals/ui/authentication/SignUpTest.kt
Show resolved
Hide resolved
app/src/androidTest/java/com/android/periodpals/ui/authentication/SignUpTest.kt
Outdated
Show resolved
Hide resolved
Replaced ``when`(navigationActions.currentRoute()).thenReturn(Route.ALERT_LIST) ` with correct return screen (`Screen.SIGN_UP`). Replaced "User is logged up" by "signed up". Completed empty email tests and others with the missing "signUpConfirmPassword". Added a test for the edge case where only the confirm-password and only the password field is empty. Suppress the useless TODO.
francelu
approved these changes
Oct 31, 2024
charliemangano
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix UI tests for M1: SignUp
Description
This PR introduces UI tests for the SignUpScreen component in the authentication module. It validates various user input scenarios to ensure proper error handling and navigation flow. It closes issue #76.
Changes
I added more tests, including tests for the calls to the ViewModel. Now the navigation tests also work.
Files
Modified
SignUpScreenTest.kt