Skip to content

ParseXS: fix space translation for $ntype #23665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: blead
Choose a base branch
from
Open

ParseXS: fix space translation for $ntype #23665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Node.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1382,9 +1382,10 @@ sub lookup_input_typemap {

my $typemaps = $pxs->{typemaps_object};

# Normalised type ('Foo *' becomes 'FooPtr): one of the valid vars
# which can appear within a typemap template.
# Normalised type ('struct Foo *' becomes 'struct_FooPtr): one of
# the valid vars which can appear within a typemap template.
(my $ntype = $type) =~ s/\s*\*/Ptr/g;
$ntype =~ s/\s/_/g;

# $subtype is really just for the T_ARRAY / DO_ARRAY_ELEM code below,
# where it's the type of each array element. But it's also passed to
Expand Down
5 changes: 3 additions & 2 deletions dist/ExtUtils-ParseXS/lib/perlxstypemap.pod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,9 @@ e.g. for a type of C<Foo::Bar>, I<$type> is C<Foo__Bar>

=item *

I<$ntype> - the supplied type with C<*> replaced with C<Ptr>.
e.g. for a type of C<Foo*>, I<$ntype> is C<FooPtr>
I<$ntype> - the supplied type with C<*> replaced with C<Ptr> and
C<\s> replaced with C<_>.
e.g. for a type of C<struct Foo*>, I<$ntype> is C<struct_FooPtr>

=item *

Expand Down
Loading