Initial overhaul of S_intuit_more #23764
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khwilliamson
force-pushed
the
initial_intuit_more
branch
3 times, most recently
from
c88e111 to
23656e0
Compare
The source to parse must be in the buffer terminated at PL_bufend. This was not obvious to me; this assertion would have caught my error earlier.
This checks first if there is a lexical variable in scope with the given name, and if not, if there is a global
khwilliamson
force-pushed
the
initial_intuit_more
branch
from
23656e0 to
cbe1dc5
Compare
Most code these days runs under 'use strict'. That allows us to resolve ambiguity without resorting to heuristics in far more cases than before. This commit adds a parameter to intuit_more() that gives the context it is being called from. And when that call is to resolve what $foo[...] is supposed to mean, we can look up foo to see if it is an array or a scalar. If the former, the "..." must be a subscript; if a scalar, it must be a charclass. Only if there is both a $foo and an @foo is there ambiguity. If so, we drop down to using the heuristics
khwilliamson
force-pushed
the
initial_intuit_more
branch
from
cbe1dc5 to
399f385
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit greatly improves this function, often eliminating the need for heuristics when
use strictis in effect, and looking for lexical variables besides globals.There is plenty more problems with this function, but this gets the majority, as
use strictis in effect most of the time these days.I really don't know much about parsing, so there could easily be some oversights here; Reviews especially welcome