perlapi: Combine all forms of Sv[INU] into one entry each #23851
Conversation
sv_inline.h
Outdated
| conversions. Only use when you are sure C<SvIOK> is true. | ||
| C<SvIVXx> is a deprecated synonym for C<SvIVX>. |
There was a problem hiding this comment.
Why are and when were the x suffix names deprecated? (and was that perldeltaed?)
They still the right thing in older perls and harmlessly do the right thing in newer perls.
There was a problem hiding this comment.
It appears that only SvUVXx had been deprecated, contrary to my recollection. And it happened in
commit b7822a6
Author: Karl Williamson khw@cpan.org
Date: Sun Aug 4 18:03:03 2019 -0600
I don't remember why. But they certainly don't have to be deprecated. It turns out they were added in
commit 463ee0b
Author: Larry Wall larry@wall.org
Date: Wed Nov 10 00:00:00 1993 +0000
perl 5.0 alpha 4
and remained pretty much untouched since.
I've never seen them used. Not that these are not the same as SvIVx, which was the form that untill 5.37 was the only one that guaranteed single evaluation
There was a problem hiding this comment.
I've never seen them used. Not that these are not the same as SvIVx, which was the form that untill 5.37 was the only one that guaranteed single evaluation
grepping CPAN finds several uses of SvNVx, SvIVx, SvUVx though I didn't see any uses that take advantage of the "single-use" property of these alternative macros.
I looked at the code, and SvUVX looks at the UV slot; so this is a typo
This makes perlapi more compact, and at the same time, easier for readers to compare them and decide which form is best suited for their purposes.
|
Thinking about it, I don't think the big X forms (SvNVX* etc) should be combined with the non-X forms. The non-X forms are the typical use forms, if you want an integer or NV you call these. The X forms are for low-level structure access and shouldn't be used unless you have a certain level of knowledge. |
2 participants
This makes perlapi more compact, and at the same time, easier for readers to compare these forms and decide which is best suited for their purposes.