perly - simplify non-terminal bare_statement_for #23873
Open
+1,570
−1,646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 22, 2025 20:48
forming sequence `KW_FOR remember` allowing simplification of following sequences and merging branches.
PERLY_PAREN_OPEN mexpr PERLY_PAREN_CLOSE
Introduce new non-terminal to handle possible variants of for loop cursors, allowing to reduce complexity of `bare_statement_for`.
and delete related `bare_statement_for` branch
happy-barney
force-pushed
the
hpb/cleanup
branch
from
ecff147 to
30c084c
Compare
added 3 commits
October 23, 2025 09:14
and delete related `bare_statement_for` branch
and delete related `bare_statement_for` branch
and delete related `bare_statement_for` branch
happy-barney
force-pushed
the
hpb/cleanup
branch
from
30c084c to
4d18cbb
Compare
happy-barney
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By extracting various declarations of cursor variable(s) into dedicated non-terminal
for statement now contains only 3 branches:
for (;;)for ()for cursor ()with LALR(1) parser
cursorcannot be empty -> it will produce conflict withfor (;;)form.