Fix bug with UTF-8 pattern group name; and document the rules #23876
+20
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2 tests failing in t/re/reg_mesg.t. |
This just fills out a couple of tests so that they don't prematurely end. That makes it clear that the eorror that does get shown isn't also due to other mistakes in the test.
This was written before Unicode, and its wording does not accurately extend beyond ASCII. This commit clarifies the description.
I found this by reading the code. Prior to this commit, the parse pointer was advanced by one byte; it should be advanced by one character. As long as the the character was ASCII, things worked. I looked through the regcomp.c source for other mis-use of the macro changed by this commit; none were obvious.
khwilliamson
force-pushed
the
regcomp_inc_by_1
branch
from
5cd7e05 to
bdade0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an illegal group name in UTF-8, the pointer to the problematic character could be pointing to an incomplete character. because the code neglected to consider if the name was UTF-8 or not.
The description of what a legal name is had not been updated to include UTF-8 names.