Skip to content

Commit

Permalink
Remove commonjs specification
Browse files Browse the repository at this point in the history
The new tsconfig for node18 requires `module` to be a valid value for
the specified `moduleResolution`.  Our override resulted in a conflict.

The `Node16` module setting *allows* esm exports.  This is a bit of
a moot point for that particular config since the whole point is that it
is a configuration for common JS.  Nevertheless, it feels better to not
override if we don't need to override, and the default behavior still
exports CJS.
  • Loading branch information
slifty committed Sep 5, 2023
1 parent 0297bbe commit e610ee4
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tsconfig.node.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"extends": "@tsconfig/node18/tsconfig.json",
"compilerOptions": {
"module": "commonjs",
"outDir": "dist/cjs",
"declaration": true,
"allowSyntheticDefaultImports": true
Expand Down

0 comments on commit e610ee4

Please sign in to comment.