Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw on non-ok server responses #155

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Throw on non-ok server responses #155

merged 1 commit into from
Aug 21, 2023

Commits on Aug 21, 2023

  1. Throw on non-ok server responses 

    When the server responds with a non-ok status we want to communicate
that response to the calling code base via a thrown error.  Prior to
this commit server errors would often be completely ignored and could
result in odd validation errors instead of communicating the actual
issue.

As part of this change our delete functions now *throw* when something
goes wrong, and so the type signature has been updated to no longer
return `boolean` to indicate success but rather a `void`.

Issue #59 Handle server errors explicitly
Issue #89 Evalauate return types for operation methods
    @slifty
    slifty committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    f130b8f View commit details
    Browse the repository at this point in the history