Raise presigned URL timeout to 24 hours for multipart uploads #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically, our presigned URLs for uploads have expired after 1 hour. This makes sense for the uploads we've been doing, where the presigned URL would be hit near instantly after it was created, but in a large multipart upload it may be some time before each URL has been called. To address this, this commit raises the timeout for presigned URLs involved in a multipart upload to 24 hours.
cecilia-donnelly
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, our presigned URLs for uploads have expired after 1 hour. This makes sense for the uploads we've been doing, where the presigned URL would be hit near instantly after it was created, but in a large multipart upload it may be some time before each URL has been called. To address this, this commit raises the timeout for presigned URLs involved in a multipart upload to 24 hours.