Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve expansion packs to handle assumptions. #146

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Improve expansion packs to handle assumptions. #146

merged 2 commits into from
Jun 4, 2020

Conversation

enadeau
Copy link
Member

@enadeau enadeau commented Jun 4, 2020

No description provided.

@enadeau enadeau requested a review from christianbean June 4, 2020 16:16
christianbean
christianbean approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@christianbean christianbean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it to MonotoneTreeVerificationStrategy's pack also

@enadeau
Copy link
Member Author

enadeau commented Jun 4, 2020

We can merge this PR as is but I think it's not the right approach to monotone tree verification. See #149

@enadeau enadeau merged commit a8a9356 into develop Jun 4, 2020
@enadeau enadeau deleted the ass-expansion branch June 4, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianbean christianbean christianbean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enadeau @christianbean