fix(orchestra): detect phantom PRs — 3-layer defense against hallucin…#183
Merged
fix(orchestra): detect phantom PRs — 3-layer defense against hallucin…#183
Conversation
…ated PR claims Models (especially Grok) can claim "PR #3 created successfully" when github_create_pr actually failed with guardrail violations. This adds three layers of protection: Fix 2: Tag github_create_pr errors with unmistakable ❌ PR NOT CREATED banner + "Do NOT claim a PR was created" instruction in tool result. Fix 3: validateOrchestraResult() cross-references parsed ORCHESTRA_RESULT against all tool outputs — if failure patterns found (Destructive update blocked, INCOMPLETE REFACTOR, DATA FABRICATION, etc.) with no matching success evidence, flags as phantom PR and clears the URL. Fix 1: Post-execution PR verification via GitHub API — after all parsing, if a PR URL survives, verify it actually exists (GET /repos/.../pulls/N). Non-fatal on network errors, but catches any edge case the other layers miss. https://claude.ai/code/session_01K2mQTABDGY7DnnposPdDjw
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
E2E Test Recording (workers-ai)❌ Tests failed
|
E2E Test Recording (discord)❌ Tests failed
|
E2E Test Recording (base)❌ Tests failed
|
E2E Test Recording (telegram)❌ Tests failed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ated PR claims
Models (especially Grok) can claim "PR #3 created successfully" when github_create_pr actually failed with guardrail violations. This adds three layers of protection:
Fix 2: Tag github_create_pr errors with unmistakable ❌ PR NOT CREATED banner + "Do NOT claim a PR was created" instruction in tool result.
Fix 3: validateOrchestraResult() cross-references parsed ORCHESTRA_RESULT against all tool outputs — if failure patterns found (Destructive update blocked, INCOMPLETE REFACTOR, DATA FABRICATION, etc.) with no matching success evidence, flags as phantom PR and clears the URL.
Fix 1: Post-execution PR verification via GitHub API — after all parsing, if a PR URL survives, verify it actually exists (GET /repos/.../pulls/N). Non-fatal on network errors, but catches any edge case the other layers miss.
https://claude.ai/code/session_01K2mQTABDGY7DnnposPdDjw