fix(review+routing): reviewer uses latest user question, routing igno…#185
Merged
fix(review+routing): reviewer uses latest user question, routing igno…#185
Conversation
…res conversation length Two bugs found during Phase 7B.6 benchmark: 1. extractUserQuestion() iterated forward and returned the FIRST user message. In multi-turn conversations the reviewer evaluated the assistant's answer against the wrong question (e.g. "capital of France" instead of "read README.md and summarize"). Fixed by iterating backwards. Also skips 7B.4 file-injection blocks. 2. Model routing used classifyTaskComplexity(msg, conversationLength) which gates on conversationLength >= 3 → 'complex', preventing simple messages from routing to fast models in longer conversations. Fixed by passing conversationLength=0 for routing decisions so only message content determines complexity. https://claude.ai/code/session_01K2mQTABDGY7DnnposPdDjw
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
E2E Test Recording (workers-ai)❌ Tests failed
|
E2E Test Recording (base)❌ Tests failed
|
E2E Test Recording (discord)❌ Tests failed
|
E2E Test Recording (telegram)❌ Tests failed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…res conversation length
Two bugs found during Phase 7B.6 benchmark:
extractUserQuestion() iterated forward and returned the FIRST user message. In multi-turn conversations the reviewer evaluated the assistant's answer against the wrong question (e.g. "capital of France" instead of "read README.md and summarize"). Fixed by iterating backwards. Also skips 7B.4 file-injection blocks.
Model routing used classifyTaskComplexity(msg, conversationLength) which gates on conversationLength >= 3 → 'complex', preventing simple messages from routing to fast models in longer conversations. Fixed by passing conversationLength=0 for routing decisions so only message content determines complexity.
https://claude.ai/code/session_01K2mQTABDGY7DnnposPdDjw