Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Working, accurate, bySource schema #16

Merged
merged 7 commits into from
Feb 11, 2024
Merged

Working, accurate, bySource schema #16

merged 7 commits into from
Feb 11, 2024

Conversation

MrVauxs
Copy link
Contributor

@MrVauxs MrVauxs commented Feb 11, 2024

Creating this as a PR to let @Spappz look through and do the file generation properly, I am certain schemaIndex should be somewhere else :wokejoy:

@MrVauxs MrVauxs requested a review from Spappz as a code owner February 11, 2024 12:06
Spappz
Spappz approved these changes Feb 11, 2024
View reviewed changes
Copy link
Member

@Spappz Spappz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gonna make some changes on top of this but it's good enough for now 👍

@Spappz Spappz merged commit 61a629d into master Feb 11, 2024
1 check passed
@Spappz Spappz deleted the objectIndex branch February 27, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spappz Spappz Spappz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrVauxs @Spappz