Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove ESPEI 0.9 deprecations (plotting and scheduler="None") #257

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
d35632b
Almost entirely passing
bocklund Jul 30, 2024
226deee
non_equilibrium_thermochemical_error cleanup
bocklund Jul 30, 2024
1803fb7
Delete unusued shadow_functions
bocklund Aug 2, 2024
4926a6c
Remove usages of approximate equilibrium in test_error_functions - it…
bocklund Aug 2, 2024
9083c5b
slight tolerance adjustment to make test pass. i think it's fine it's…
bocklund Aug 2, 2024
39bb89e
drop py 38
bocklund Aug 2, 2024
5330399
Remove dead code
bocklund Aug 2, 2024
c987ac0
Time residuals
bocklund Aug 2, 2024
af4bd04
Fix internal DOF, now we're perfectly matching release version
bocklund Aug 3, 2024
fea3e2a
fix test_get_thermochemical_data_filters_invalid_sublattice_configura…
richardotis Aug 3, 2024
9f38479
set symbols_to_fit to empty list for more tests
richardotis Aug 3, 2024
d0279e0
another fixup for N=1
richardotis Aug 3, 2024
51df132
zpf_error fix for parameters
richardotis Aug 3, 2024
ad5c117
zpf_error model fix
richardotis Aug 3, 2024
55d7aab
zpf_error model None fix
richardotis Aug 3, 2024
02f9b24
unwrap model DictProxy
richardotis Aug 3, 2024
ae2ba79
matplotlib set backend for plotting tests
richardotis Aug 3, 2024
aae1565
Remove `points` from RegionVertex
bocklund Aug 6, 2024
76e0e91
Support v.Component
bocklund Aug 8, 2024
7b172da
phase_records -> PhaseRecordFactory
bocklund Aug 8, 2024
37f66f2
delete dead imports
bocklund Aug 8, 2024
7e9ede5
Fix source of extra points dimensions in plot_interaction
bocklund Aug 8, 2024
74c5c51
Remove espei.plot 0.9 deprecations
bocklund Aug 8, 2024
bd9c18b
Remove deprecated "None" scheduler string
bocklund Aug 8, 2024
e05549b
Merge branch 'master' into remove-espei-0.9-deprecations
bocklund Aug 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions espei/espei_script.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,6 @@ def get_run_settings(input_dict):
if run_settings['mcmc'].get('restart_trace') is None:
run_settings['mcmc']['chains_per_parameter'] = run_settings['mcmc'].get('chains_per_parameter', 2)
run_settings['mcmc']['chain_std_deviation'] = run_settings['mcmc'].get('chain_std_deviation', 0.1)
if run_settings['mcmc']['scheduler'] == 'None':
warnings.warn(
"Setting scheduler to the string 'None' will be deprecated in ESPEI "
"0.9. Use `null` in YAML or `None` in Python.", FutureWarning
)
run_settings['mcmc']['scheduler'] = None
if not schema.validate(run_settings):
raise ValueError(schema.errors)
if run_settings.get("generate_parameters") is not None:
Expand Down
4 changes: 2 additions & 2 deletions espei/input-schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ mcmc:
required: True
scheduler: # scheduler to use for parallelization
type: string
default: dask # dask | None | A JSON file
regex: 'dask|None|.*\.json$'
default: dask # dask | A JSON file
regex: 'dask|.*\.json$'
required: True
nullable: True
cores:
Expand Down
Loading
Loading