Skip to content

Simplify traits attribute value access and storage operations #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 54 commits into from
Jul 21, 2025
Merged

Simplify traits attribute value access and storage operations #1236

merged 54 commits into from
Jul 21, 2025

Conversation

kamathprasad9
Copy link
Collaborator

@kamathprasad9 kamathprasad9 commented May 4, 2025 •
edited by trife
Loading

Description

Adds a helper class to provide a better way to manage ObservationVariable's attribute-value saving and storage

Change Type

  • ADDITION (non-breaking change that adds functionality)
  • CHANGE (fix or feature that alters existing functionality)
  • FIX (non-breaking change that resolves an issue)
  • OTHER (use only for changes like tooling, build system, CI, docs, etc.)

Release Note

Release Type

For internal use - please leave these unchecked unless you are the one completing the merge.

  • MAJOR
  • MINOR
  • WAIT (No immediate release, but the changelog will be still be updated if there is a release note.)

chaneylc and others added 30 commits March 18, 2025 16:18
@chaneylc
init commit for basic nix color sensor
ec65026
@chaneylc
added nix to trait creator
99ddc72
@kamathprasad9
Add fields grouping
cc3b1bc
@kamathprasad9
Merge branch 'main' into group-fields
37a538e
@kamathprasad9
Add archived as a list item
17a7344
@kamathprasad9
Move archive field option to menu bar
1cd5a34
@kamathprasad9
Add archived fields activity
c5177d1
@kamathprasad9
Merge remote-tracking branch 'origin/migrator_interface' into group-f…
496d1c9 
…ields
@kamathprasad9
Create study_group table, add isArchived to studies table
60824a2
@kamathprasad9
Toggle grouping
afe55d6
@kamathprasad9
Fix search filtering
6e941f7
@kamathprasad9
Sort groups by name
3e8ffa8
@kamathprasad9
Select fields on group long click
652e044
@chaneylc
Merge branch 'main' into nix
7e08ad5 
# Conflicts:
#	app/build.gradle
#	app/src/main/java/com/fieldbook/tracker/traits/formats/Formats.kt
#	build.gradle
@chaneylc
init commit for spectral traits, nix implementation
93f8f1f
@kamathprasad9
Assign group to brapi imported field
41713cb
@kamathprasad9
Set study trial name for old import UI
ecbe800
@kamathprasad9
Add isExpanded to StudyGroups to persist state
23400ba
@kamathprasad9
Always fix ungrouped to the bottom
a1e4cb1
@kamathprasad9
Add group size in header
cbb41e3
@kamathprasad9
Scroll when grouping enabled/disabled
a0e7b71
@kamathprasad9
Expand group on long press
6503a1d
@kamathprasad9
Show grouping icon only if a group or archived field exists
044c63e
@kamathprasad9
Add collapse/expand all options, add StudyGroupModel
b4ff8ed
@kamathprasad9
Fix group reordering when fields are ungrouped
4880e1e
@kamathprasad9
Add group name to field detail
6a64d23
@kamathprasad9
Add string res
d4d513b
@kamathprasad9
Remove archived icon, group chip if trial name is same
4da8fe4
@kamathprasad9
Force group visibility when grouped/archived fields are present/absent
264f015
@kamathprasad9
Fix view item type check
b505391
chaneylc
chaneylc requested changes May 7, 2025
View reviewed changes
Copy link
Member

@chaneylc chaneylc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the improvements, but I think we can go a step further with the 'details' query I describe.

@chaneylc
Copy link
Member

chaneylc commented May 8, 2025 •
edited
Loading

It's also worth adding BrAPI unit attributes, look at the BrAPI usages of createFieldData when a study is saved in the service.

@kamathprasad9
Fix archived field menu bar overlay issue
5e76a16
@kamathprasad9
Use datahelper instead of DAOs using interface
7ea200a
@kamathprasad9
Merge remote-tracking branch 'origin/nix' into group-fields
71ed595
@kamathprasad9
Adapt to origin/nix changes
bf744aa
@kamathprasad9
Remove camel case columns, add StudyGroupsTable object
01c26e0
@kamathprasad9
Fix select all, exitSelectionMode status
5b7ced0
@kamathprasad9
Handle possible getColumnIndexOrThrow exceptions
3dd9249
@kamathprasad9
Use BaseFieldActivity
f8f8b80
@kamathprasad9
Add warning while archiving active field
3564fc4
@kamathprasad9
Use ActivityResultLauncher instead of onActivityResult
45b96be
@kamathprasad9
Fix cloud import file copying in import dir
0388f31
@kamathprasad9
Switch to field when 1 brapi field is imported in new UI
f8261e3
@kamathprasad9
Fix active field background bug when loadLocal/create field
1f561ae
@kamathprasad9
Enter selection mode when group long pressed
c4e792e
@kamathprasad9
Fix archive warning dialog padding
b9cbad4
@kamathprasad9 kamathprasad9 force-pushed the simplify-attribute-value branch from 9d3a5b3 to 787b707 Compare May 22, 2025 01:37
@kamathprasad9 kamathprasad9 changed the base branch from main to group-fields May 27, 2025 04:08
@kamathprasad9 kamathprasad9 requested a review from chaneylc July 9, 2025 00:40
@kamathprasad9 kamathprasad9 changed the base branch from group-fields to issue_471_database_query_name_usages July 21, 2025 02:59
@trife trife merged commit efbd368 into issue_471_database_query_name_usages Jul 21, 2025
@trife trife deleted the simplify-attribute-value branch July 21, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaneylc chaneylc chaneylc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamathprasad9 @chaneylc @trife